mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Alert transport cleanup, no_proxy support and other proxy cleanups (#14763)

Browse Source 
* Add no_proxy and other proxy related settings
Set user agent on all http client requests
Unify http client usage

* Style fixes

* Remove useless use statements

* Correct variable, good job phpstan

* Add tests
fix https_proxy bug
add tcp:// to the config settings format

* style and lint fixes

* Remove guzzle from the direct dependencies

* Use built in Laravel testing functionality

* update baseline
This commit is contained in:
Tony Murray
2023-05-23 09:25:17 -05:00
committed by GitHub
parent 02896172bd
commit 04bb75f5f3
78 changed files with 1545 additions and 2314 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
LibreNMS/Alert/Transport/Pushover.php
View File

@@ -39,68 +39,57 @@ namespace LibreNMS\Alert\Transport;
use LibreNMS\Alert\Transport;
use LibreNMS\Enum\AlertState;
use LibreNMS\Util\Proxy;
use LibreNMS\Exceptions\AlertTransportDeliveryException;
use LibreNMS\Util\Http;
class Pushover extends Transport
{
public function deliverAlert($obj, $opts)
public function deliverAlert(array $alert_data): bool
{
$pushover_opts = $this->config;
$pushover_opts['options'] = $this->parseUserOptions($this->config['options']);
$options = $this->parseUserOptions($this->config['options']);
return $this->contactPushover($obj, $pushover_opts);
}
public function contactPushover($obj, $api)
{
$url = 'https://api.pushover.net/1/messages.json';
$data = [];
$data['token'] = $api['appkey'];
$data['user'] = $api['userkey'];
switch ($obj['severity']) {
$data['token'] = $this->config['appkey'];
$data['user'] = $this->config['userkey'];
switch ($alert_data['severity']) {
case 'critical':
$data['priority'] = 1;
if (! empty($api['options']['sound_critical'])) {
$data['sound'] = $api['options']['sound_critical'];
if (! empty($options['sound_critical'])) {
$data['sound'] = $options['sound_critical'];
}
break;
case 'warning':
$data['priority'] = 1;
if (! empty($api['options']['sound_warning'])) {
$data['sound'] = $api['options']['sound_warning'];
if (! empty($options['sound_warning'])) {
$data['sound'] = $options['sound_warning'];
}
break;
}
switch ($obj['state']) {
switch ($alert_data['state']) {
case AlertState::RECOVERED:
$data['priority'] = 0;
if (! empty($api['options']['sound_ok'])) {
$data['sound'] = $api['options']['sound_ok'];
if (! empty($options['sound_ok'])) {
$data['sound'] = $options['sound_ok'];
}
break;
}
$data['title'] = $obj['title'];
$data['message'] = $obj['msg'];
if ($api['options']) {
$data = array_merge($data, $api['options']);
}
$curl = curl_init();
Proxy::applyToCurl($curl);
curl_setopt($curl, CURLOPT_URL, 'https://api.pushover.net/1/messages.json');
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
curl_setopt($curl, CURLOPT_SAFE_UPLOAD, true);
curl_setopt($curl, CURLOPT_POSTFIELDS, $data);
$ret = curl_exec($curl);
$code = curl_getinfo($curl, CURLINFO_HTTP_CODE);
if ($code != 200) {
var_dump('Pushover returned error'); //FIXME: proper debugging
return 'HTTP Status code ' . $code;
$data['title'] = $alert_data['title'];
$data['message'] = $alert_data['msg'];
if ($options) {
$data = array_merge($data, $options);
}
return true;
$res = Http::client()->asForm()->post($url, $data);
if ($res->successful()) {
return true;
}
throw new AlertTransportDeliveryException($alert_data, $res->status(), $res->body(), $data['message'], $data);
}
public static function configTemplate()
public static function configTemplate(): array
{
return [
'config' => [