mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix api transport mult-line parsing (#13469)

Browse Source 
* API transport fix parsing
parse templates after parsing user options, not before

* API transport tests

* fix style and lint

* remove accidental item

* fix more type issues
This commit is contained in:
Tony Murray
2021-11-03 13:37:57 -05:00
committed by GitHub
parent 01345b5fba
commit 0862496e26
8 changed files with 239 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tests/Unit/Data/PrometheusStoreTest.php
View File

@@ -25,22 +25,21 @@
namespace LibreNMS\Tests\Unit\Data;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Handler\MockHandler;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Middleware;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use LibreNMS\Config;
use LibreNMS\Data\Store\Prometheus;
use LibreNMS\Tests\TestCase;
use LibreNMS\Tests\Traits\MockGuzzleClient;
/**
* @group datastores
*/
class PrometheusStoreTest extends TestCase
{
use MockGuzzleClient;
protected function setUp(): void
{
parent::setUp();
@@ -51,13 +50,12 @@ class PrometheusStoreTest extends TestCase
public function testFailWrite()
{
$stack = HandlerStack::create(new MockHandler([
$this->mockGuzzleClient([
new Response(422, [], 'Bad response'),
new RequestException('Exception thrown', new Request('POST', 'test')),
]));
]);
$client = new Client(['handler' => $stack]);
$prometheus = new Prometheus($client);
$prometheus = app(Prometheus::class);
\Log::shouldReceive('debug');
\Log::shouldReceive('error')->once()->with("Prometheus Exception: Client error: `POST http://fake:9999/metrics/job/librenms/instance/test/measurement/none` resulted in a `422 Unprocessable Entity` response:\nBad response\n");
@@ -68,16 +66,11 @@ class PrometheusStoreTest extends TestCase
public function testSimpleWrite()
{
$stack = HandlerStack::create(new MockHandler([
$this->mockGuzzleClient([
new Response(200),
]));
]);
$container = [];
$history = Middleware::history($container);
$stack->push($history);
$client = new Client(['handler' => $stack]);
$prometheus = new Prometheus($client);
$prometheus = app(Prometheus::class);
$device = ['hostname' => 'testhost'];
$measurement = 'testmeasure';
@@ -89,15 +82,12 @@ class PrometheusStoreTest extends TestCase
$prometheus->put($device, $measurement, $tags, $fields);
$this->assertCount(1, $container, 'Did not receive the expected number of requests');
/** @var Request $request */
$request = $container[0]['request'];
$this->assertEquals('POST', $request->getMethod());
$this->assertEquals('/metrics/job/librenms/instance/testhost/measurement/testmeasure/ifName/testifname/type/testtype', $request->getUri()->getPath());
$this->assertEquals('fake', $request->getUri()->getHost());
$this->assertEquals(9999, $request->getUri()->getPort());
$this->assertEquals("ifIn 234234\nifOut 53453\n", (string) $request->getBody());
$history = $this->guzzleRequestHistory();
$this->assertCount(1, $history, 'Did not receive the expected number of requests');
$this->assertEquals('POST', $history[0]->getMethod());
$this->assertEquals('/metrics/job/librenms/instance/testhost/measurement/testmeasure/ifName/testifname/type/testtype', $history[0]->getUri()->getPath());
$this->assertEquals('fake', $history[0]->getUri()->getHost());
$this->assertEquals(9999, $history[0]->getUri()->getPort());
$this->assertEquals("ifIn 234234\nifOut 53453\n", (string) $history[0]->getBody());
}
}