From 0a34a37d9ee2cc620b9c6ccfc7f7367b998edf0e Mon Sep 17 00:00:00 2001 From: Tony Murray Date: Sat, 25 Aug 2018 06:10:00 -0500 Subject: [PATCH] Fixed xss in deluser (#9079) DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply `, i.e `./scripts/github-apply 5926` --- html/pages/deluser.inc.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/html/pages/deluser.inc.php b/html/pages/deluser.inc.php index 1ba4eaed16..c0baf9ce87 100644 --- a/html/pages/deluser.inc.php +++ b/html/pages/deluser.inc.php @@ -13,16 +13,17 @@ if (!Auth::user()->isAdmin()) { if (Auth::get()->canManageUsers()) { if ($vars['action'] == 'del') { - $delete_username = dbFetchCell('SELECT username FROM users WHERE user_id = ?', array($vars['id'])); + $id = (int)$vars['id']; + $delete_username = dbFetchCell('SELECT username FROM users WHERE user_id = ?', [$id]); if ($vars['confirm'] == 'yes') { - if (Auth::get()->deleteUser($vars['id']) >= 0) { + if (Auth::get()->deleteUser($id) >= 0) { print_message('
User "'.$delete_username.'" deleted!'); } else { print_error('Error deleting user "'.$delete_username.'"!'); } } else { - print_error('You have requested deletion of the user "'.$delete_username.'". This action can not be reversed.
Click to confirm'); + print_error('You have requested deletion of the user "'.$delete_username.'". This action can not be reversed.
Click to confirm'); } }