mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't update ospf stats if there are none. (#9133)

Browse Source 
Also fixes fatal error ->count() on null.
This commit is contained in:
Tony Murray
2018-09-02 17:42:50 -05:00
committed by Neil Lathwood
parent 30790bafd1
commit 0f0ae34d77
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
includes/polling/ospf.inc.php
View File

@@ -142,22 +142,24 @@ foreach ($vrfs_lite_cisco as $vrf_lite) {
unset($device['context_name'], $vrfs_lite_cisco, $vrf_lite); unset($device['context_name'], $vrfs_lite_cisco, $vrf_lite);
// Create device-wide statistics RRD if ($instance_count) {
$rrd_def = RrdDefinition::make() // Create device-wide statistics RRD
->addDataset('instances', 'GAUGE', 0, 1000000) $rrd_def = RrdDefinition::make()
->addDataset('areas', 'GAUGE', 0, 1000000) ->addDataset('instances', 'GAUGE', 0, 1000000)
->addDataset('ports', 'GAUGE', 0, 1000000) ->addDataset('areas', 'GAUGE', 0, 1000000)
->addDataset('neighbours', 'GAUGE', 0, 1000000); ->addDataset('ports', 'GAUGE', 0, 1000000)
->addDataset('neighbours', 'GAUGE', 0, 1000000);
$fields = [ $fields = [
'instances' => $instance_count, 'instances' => $instance_count,
'areas' => $ospf_areas->count(), 'areas' => $ospf_areas->count(),
'ports' => $ospf_ports->count(), 'ports' => $ospf_ports->count(),
'neighbours' => $ospf_neighbours->count(), 'neighbours' => $ospf_neighbours->count(),
]; ];
$tags = compact('rrd_def'); $tags = compact('rrd_def');
data_update($device, 'ospf-statistics', $tags, $fields); data_update($device, 'ospf-statistics', $tags, $fields);
}
echo PHP_EOL; echo PHP_EOL;