mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove array_push is inefficient and we dont care about its return value

Browse Source
This commit is contained in:
Tyler Christiansen
2015-04-07 14:03:30 -07:00
parent d4f472e9cb
commit 1663b743db
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
html/includes/authentication/ldap.inc.php
View File

@@ -214,12 +214,12 @@ function get_group_list() {
$default_group = 'cn=groupname,ou=groups,dc=example,dc=com'; $default_group = 'cn=groupname,ou=groups,dc=example,dc=com';
if(isset($config['auth_ldap_group'])) { if(isset($config['auth_ldap_group'])) {
if($config['auth_ldap_group'] !== $default_group) { if($config['auth_ldap_group'] !== $default_group) {
array_push($ldap_groups, $config['auth_ldap_group']); $ldap_groups[] = $config['auth_ldap_group'];
} }
} }
foreach($config['auth_ldap_groups'] as $key => $value) { foreach($config['auth_ldap_groups'] as $key => $value) {
$dn = "cn=$key," . $config['auth_ldap_groupbase']; $dn = "cn=$key," . $config['auth_ldap_groupbase'];
array_push($ldap_groups, $dn); $ldap_groups[] = $dn;
} }
return $ldap_groups; return $ldap_groups;
} }