mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Silence return type mismatch (#14298)

Browse Source 
* Silence return type mismatch

To keep PHP7 compatibility

* Update QueryBuilderFilter.php

* Update DynamicConfigItem.php

* Update ObjectCache.php

* Update DynamicConfigItem.php
This commit is contained in:
Jellyfrog
2022-09-05 23:19:39 +02:00
committed by GitHub
parent 93572cd5d3
commit 2264229b8b
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
LibreNMS/Alerting/QueryBuilderFilter.php
View File

@@ -170,6 +170,7 @@ class QueryBuilderFilter implements \JsonSerializable
* *
* @since 5.4.0 * @since 5.4.0
*/ */
#[\ReturnTypeWillChange]
public function jsonSerialize() public function jsonSerialize()
{ {
$filter = $this->filter; $filter = $this->filter;

1
LibreNMS/Alerting/QueryBuilderParser.php
View File

@@ -467,6 +467,7 @@ class QueryBuilderParser implements \JsonSerializable
* *
* @since 5.4.0 * @since 5.4.0
*/ */
#[\ReturnTypeWillChange]
public function jsonSerialize() public function jsonSerialize()
{ {
return $this->builder; return $this->builder;

23
LibreNMS/ObjectCache.php
View File

@@ -70,10 +70,10 @@ class ObjectCache implements ArrayAccess
/** /**
* Check if data exists * Check if data exists
* *
* @param string $obj Name of Data-Object * @param mixed $obj Name of Data-Object
* @return bool * @return bool
*/ */
public function offsetExists($obj) public function offsetExists($obj): bool
{ {
if (isset($this->data[$obj])) { if (isset($this->data[$obj])) {
return true; return true;
@@ -87,9 +87,10 @@ class ObjectCache implements ArrayAccess
/** /**
* Get Data-Object * Get Data-Object
* *
* @param string $obj Name of Data-Object * @param mixed $obj Name of Data-Object
* @return mixed * @return mixed
*/ */
#[\ReturnTypeWillChange]
public function offsetGet($obj) public function offsetGet($obj)
{ {
if (isset($this->data[$obj])) { if (isset($this->data[$obj])) {
@@ -113,19 +114,17 @@ class ObjectCache implements ArrayAccess
/** /**
* Overrides internal Cache-Object * Overrides internal Cache-Object
* *
* @param string $obj Name of Data-Object * @param mixed $obj Name of Data-Object
* @param mixed $value Value * @param mixed $value Value
* @return bool * @return void
*/ */
public function offsetSet($obj, $value) public function offsetSet($obj, $value): void
{ {
if (! isset($this->data[$obj])) { if (! isset($this->data[$obj])) {
$this->data[$obj] = []; $this->data[$obj] = [];
} }
$this->data[$obj]['value'] = $value; $this->data[$obj]['value'] = $value;
return $this->data[$obj]['value'];
} }
//end offsetSet() //end offsetSet()
@@ -133,14 +132,12 @@ class ObjectCache implements ArrayAccess
/** /**
* Reset Data-Object * Reset Data-Object
* *
* @param string $obj Name of Data-Object * @param mixed $obj Name of Data-Object
* @return mixed * @return void
*/ */
public function offsetUnset($obj) public function offsetUnset($obj): void
{ {
unset($this->data[$obj]['value']); unset($this->data[$obj]['value']);
return true;
} }
//end offsetUnset() //end offsetUnset()

7
LibreNMS/Util/DynamicConfigItem.php
View File

@@ -219,22 +219,23 @@ class DynamicConfigItem implements \ArrayAccess
} }
// ArrayAccess functions // ArrayAccess functions
public function offsetExists($offset) public function offsetExists($offset): bool
{ {
return isset($this->$offset); return isset($this->$offset);
} }
#[\ReturnTypeWillChange]
public function offsetGet($offset) public function offsetGet($offset)
{ {
return isset($this->$offset) ? $this->$offset : null; return isset($this->$offset) ? $this->$offset : null;
} }
public function offsetSet($offset, $value) public function offsetSet($offset, $value): void
{ {
$this->$offset = $value; $this->$offset = $value;
} }
public function offsetUnset($offset) public function offsetUnset($offset): void
{ {
unset($this->$offset); unset($this->$offset);
} }