From 25dc44a574bc9487cd9204a6742b48a1e78cf122 Mon Sep 17 00:00:00 2001 From: Tony Murray Date: Tue, 17 Jul 2018 02:16:13 -0500 Subject: [PATCH] fixed can_ping_device() logic (#8906) DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply `, i.e `./scripts/github-apply 5926` --- includes/common.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/common.php b/includes/common.php index 1e4989e5db..8ed11c4b1f 100644 --- a/includes/common.php +++ b/includes/common.php @@ -1029,8 +1029,7 @@ function object_is_cached($section, $obj) **/ function can_ping_device($attribs) { - global $config; - if ($config['icmp_check'] === true && (isset($attribs['override_icmp_disable']) && $attribs['override_icmp_disable'] != "true")) { + if (Config::get('icmp_check') && !(isset($attribs['override_icmp_disable']) && $attribs['override_icmp_disable'] == "true")) { return true; } else { return false;