From 277333c752ed4b59bdaacadc47a3b6ab78ba5209 Mon Sep 17 00:00:00 2001
From: joretapoo <loic.pailhas@blade-group.com>
Date: Wed, 26 Feb 2020 18:43:21 +0100
Subject: [PATCH] =?UTF-8?q?space=20on=20type=20like=20"OOB=20Management"?=
 =?UTF-8?q?=20cause=20issue=20on=20smokeping,=20edit=20ge=E2=80=A6=20(#111?=
 =?UTF-8?q?60)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* space on type like "OOB Management" cause issue on smokeping, edit gen_smokeping script to replace dot and space

* create fonction for replace dot and space

* correct indentation

* moving function to functions.php

* correct function name

* Remove function

this should not be a function...

* Remove function

* Update gen_smokeping.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
---
 scripts/gen_smokeping.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/scripts/gen_smokeping.php b/scripts/gen_smokeping.php
index 907d7f782f..f9887c82c6 100755
--- a/scripts/gen_smokeping.php
+++ b/scripts/gen_smokeping.php
@@ -13,7 +13,6 @@
 
 $init_modules = array();
 require realpath(__DIR__ . '/..') . '/includes/init.php';
-
 ?>
 
 menu = Top
@@ -22,12 +21,12 @@ title = Network Latency Grapher
 <?php
 
 foreach (dbFetchRows("SELECT `type` FROM `devices` WHERE `ignore` = 0 AND `disabled` = 0 AND `type` != '' GROUP BY `type`") as $groups) {
-    echo '+ ' . $groups['type'] . PHP_EOL;
+    //Dot and space need to be replaced, since smokeping doesn't accept it at this level
+    echo '+ ' . str_replace(['.', ' '], '_', $groups['type']) . PHP_EOL;
     echo 'menu = ' . $groups['type'] . PHP_EOL;
     echo 'title = ' . $groups['type'] . PHP_EOL;
     foreach (dbFetchRows("SELECT `hostname` FROM `devices` WHERE `type` = ? AND `ignore` = 0 AND `disabled` = 0", array($groups['type'])) as $devices) {
-        //Dot needs to be replaced, since smokeping doesn't accept it at this level
-        echo '++ ' . str_replace(".", "_", $devices['hostname']) . PHP_EOL;
+        echo '++ ' . str_replace(['.', ' '], '_', $devices['hostname']) . PHP_EOL;
         echo 'menu = ' . $devices['hostname'] . PHP_EOL;
         echo 'title = ' . $devices['hostname'] . PHP_EOL;
         echo 'host = ' . $devices['hostname'] . PHP_EOL . PHP_EOL;