From 2dea36f70fdcc514b1c8487156f03d75c8aafd85 Mon Sep 17 00:00:00 2001 From: Tony Murray Date: Wed, 2 Nov 2022 09:55:28 -0500 Subject: [PATCH] Remove graph_min (#14561) * Remove graph_min it doesn't do anything (scale_min sets minimum graph scale) (graph_max shows a line at max on some graphs) * fix style --- doc/Developing/os/Custom-Graphs.md | 1 - includes/html/graphs/application/opensips_load.inc.php | 1 - includes/html/graphs/device/arbos_flows.inc.php | 1 - includes/html/graphs/device/asyncos_conns.inc.php | 1 - includes/html/graphs/device/availability.inc.php | 1 - includes/html/graphs/device/barracuda_firewall_sessions.inc.php | 1 - includes/html/graphs/device/bigip_apm_sessions.inc.php | 1 - includes/html/graphs/device/bigip_gtm_pool_dropped.inc.php | 1 - includes/html/graphs/device/bigip_gtm_pool_requests.inc.php | 1 - includes/html/graphs/device/bigip_gtm_wide_dropped.inc.php | 1 - includes/html/graphs/device/bigip_gtm_wide_requests.inc.php | 1 - includes/html/graphs/device/bigip_gtm_wide_resolved.inc.php | 1 - includes/html/graphs/device/bigip_ltm_vs_conns.inc.php | 1 - includes/html/graphs/device/bigip_ltm_vs_currconns.inc.php | 1 - .../device/bigip_system_client_concurrent_connections.inc.php | 1 - .../graphs/device/bigip_system_client_connection_rate.inc.php | 1 - .../device/bigip_system_server_concurrent_connections.inc.php | 1 - .../graphs/device/bigip_system_server_connection_rate.inc.php | 1 - includes/html/graphs/device/hr_processes.inc.php | 1 - includes/html/graphs/device/hr_users.inc.php | 1 - includes/html/graphs/device/routeros_leases.inc.php | 1 - includes/html/graphs/device/routeros_pppoe_sessions.inc.php | 1 - includes/html/graphs/device/sgos_average_requests.inc.php | 1 - includes/html/graphs/device/topvision_cmoffline.inc.php | 1 - includes/html/graphs/device/topvision_cmreg.inc.php | 1 - includes/html/graphs/device/topvision_cmtotal.inc.php | 1 - .../html/graphs/device/waas_cwotfostatsactiveoptconn.inc.php | 1 - 27 files changed, 27 deletions(-) diff --git a/doc/Developing/os/Custom-Graphs.md b/doc/Developing/os/Custom-Graphs.md index e417469eed..a1d97981cd 100644 --- a/doc/Developing/os/Custom-Graphs.md +++ b/doc/Developing/os/Custom-Graphs.md @@ -84,7 +84,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Sessions'; diff --git a/includes/html/graphs/application/opensips_load.inc.php b/includes/html/graphs/application/opensips_load.inc.php index cb98a72aa4..0f2bb82bd7 100644 --- a/includes/html/graphs/application/opensips_load.inc.php +++ b/includes/html/graphs/application/opensips_load.inc.php @@ -20,7 +20,6 @@ $colour_line = 'FF4500'; $colour_area_max = 'FFEE99'; $graph_max = 1000; -$graph_min = 1; $unit_text = 'Load Average %'; diff --git a/includes/html/graphs/device/arbos_flows.inc.php b/includes/html/graphs/device/arbos_flows.inc.php index 18254801a7..c71582bfeb 100644 --- a/includes/html/graphs/device/arbos_flows.inc.php +++ b/includes/html/graphs/device/arbos_flows.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'flows'; diff --git a/includes/html/graphs/device/asyncos_conns.inc.php b/includes/html/graphs/device/asyncos_conns.inc.php index 6420edd215..ebd70388f4 100644 --- a/includes/html/graphs/device/asyncos_conns.inc.php +++ b/includes/html/graphs/device/asyncos_conns.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Connections'; diff --git a/includes/html/graphs/device/availability.inc.php b/includes/html/graphs/device/availability.inc.php index c65f788ff2..cbd209046a 100644 --- a/includes/html/graphs/device/availability.inc.php +++ b/includes/html/graphs/device/availability.inc.php @@ -18,7 +18,6 @@ $line_text = \LibreNMS\Util\Time::humanTime($vars['duration']); $graph_title .= '::' . $line_text; $graph_max = 1; -$graph_min = 0; $unit_text = 'Availability(%)'; diff --git a/includes/html/graphs/device/barracuda_firewall_sessions.inc.php b/includes/html/graphs/device/barracuda_firewall_sessions.inc.php index 6e4064c813..b43879fda7 100644 --- a/includes/html/graphs/device/barracuda_firewall_sessions.inc.php +++ b/includes/html/graphs/device/barracuda_firewall_sessions.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; //$graph_max = 1; -$graph_min = 0; $unit_text = 'Sessions'; diff --git a/includes/html/graphs/device/bigip_apm_sessions.inc.php b/includes/html/graphs/device/bigip_apm_sessions.inc.php index c60ea8edef..4feda1ed73 100644 --- a/includes/html/graphs/device/bigip_apm_sessions.inc.php +++ b/includes/html/graphs/device/bigip_apm_sessions.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Sessions'; diff --git a/includes/html/graphs/device/bigip_gtm_pool_dropped.inc.php b/includes/html/graphs/device/bigip_gtm_pool_dropped.inc.php index f91cf7ba14..5603207c34 100644 --- a/includes/html/graphs/device/bigip_gtm_pool_dropped.inc.php +++ b/includes/html/graphs/device/bigip_gtm_pool_dropped.inc.php @@ -36,7 +36,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Dropped Requests'; $line_text = 'Dropped Requests'; diff --git a/includes/html/graphs/device/bigip_gtm_pool_requests.inc.php b/includes/html/graphs/device/bigip_gtm_pool_requests.inc.php index ba422f5033..904cef0126 100644 --- a/includes/html/graphs/device/bigip_gtm_pool_requests.inc.php +++ b/includes/html/graphs/device/bigip_gtm_pool_requests.inc.php @@ -36,7 +36,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Resolved Requests'; $line_text = 'Resolved Requests'; diff --git a/includes/html/graphs/device/bigip_gtm_wide_dropped.inc.php b/includes/html/graphs/device/bigip_gtm_wide_dropped.inc.php index 811312b23f..481514fc26 100644 --- a/includes/html/graphs/device/bigip_gtm_wide_dropped.inc.php +++ b/includes/html/graphs/device/bigip_gtm_wide_dropped.inc.php @@ -36,7 +36,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Dropped Requests'; $line_text = 'Dropped Requests'; diff --git a/includes/html/graphs/device/bigip_gtm_wide_requests.inc.php b/includes/html/graphs/device/bigip_gtm_wide_requests.inc.php index 0301dd1245..5e3f26c8f8 100644 --- a/includes/html/graphs/device/bigip_gtm_wide_requests.inc.php +++ b/includes/html/graphs/device/bigip_gtm_wide_requests.inc.php @@ -36,7 +36,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Requests'; $line_text = 'Requests'; diff --git a/includes/html/graphs/device/bigip_gtm_wide_resolved.inc.php b/includes/html/graphs/device/bigip_gtm_wide_resolved.inc.php index e0178b4f62..ce93f61ef3 100644 --- a/includes/html/graphs/device/bigip_gtm_wide_resolved.inc.php +++ b/includes/html/graphs/device/bigip_gtm_wide_resolved.inc.php @@ -36,7 +36,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Resolved Requests'; $line_text = 'Resolved Requests'; diff --git a/includes/html/graphs/device/bigip_ltm_vs_conns.inc.php b/includes/html/graphs/device/bigip_ltm_vs_conns.inc.php index b7fc913d79..07cf36dc11 100644 --- a/includes/html/graphs/device/bigip_ltm_vs_conns.inc.php +++ b/includes/html/graphs/device/bigip_ltm_vs_conns.inc.php @@ -35,7 +35,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Total Connections'; $line_text = 'Connections'; diff --git a/includes/html/graphs/device/bigip_ltm_vs_currconns.inc.php b/includes/html/graphs/device/bigip_ltm_vs_currconns.inc.php index 651ebd8314..b991e8970d 100644 --- a/includes/html/graphs/device/bigip_ltm_vs_currconns.inc.php +++ b/includes/html/graphs/device/bigip_ltm_vs_currconns.inc.php @@ -35,7 +35,6 @@ if (isset($components[$vars['id']])) { $colour_area_max = '9999cc'; $graph_max = 1; - $graph_min = 0; $unit_text = 'Current Connections'; $line_text = 'Current Connections'; diff --git a/includes/html/graphs/device/bigip_system_client_concurrent_connections.inc.php b/includes/html/graphs/device/bigip_system_client_concurrent_connections.inc.php index b31b81679c..fdde6677f5 100644 --- a/includes/html/graphs/device/bigip_system_client_concurrent_connections.inc.php +++ b/includes/html/graphs/device/bigip_system_client_concurrent_connections.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Active connections'; diff --git a/includes/html/graphs/device/bigip_system_client_connection_rate.inc.php b/includes/html/graphs/device/bigip_system_client_connection_rate.inc.php index a26e4d8dab..cfef4302c6 100644 --- a/includes/html/graphs/device/bigip_system_client_connection_rate.inc.php +++ b/includes/html/graphs/device/bigip_system_client_connection_rate.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Connection Rate'; diff --git a/includes/html/graphs/device/bigip_system_server_concurrent_connections.inc.php b/includes/html/graphs/device/bigip_system_server_concurrent_connections.inc.php index efae237219..a4a1781425 100644 --- a/includes/html/graphs/device/bigip_system_server_concurrent_connections.inc.php +++ b/includes/html/graphs/device/bigip_system_server_concurrent_connections.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Active connections'; diff --git a/includes/html/graphs/device/bigip_system_server_connection_rate.inc.php b/includes/html/graphs/device/bigip_system_server_connection_rate.inc.php index 26c6b85b45..911db3b70b 100644 --- a/includes/html/graphs/device/bigip_system_server_connection_rate.inc.php +++ b/includes/html/graphs/device/bigip_system_server_connection_rate.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Connection Rate'; diff --git a/includes/html/graphs/device/hr_processes.inc.php b/includes/html/graphs/device/hr_processes.inc.php index 23dcb32401..b2c5a70bf8 100644 --- a/includes/html/graphs/device/hr_processes.inc.php +++ b/includes/html/graphs/device/hr_processes.inc.php @@ -12,7 +12,6 @@ $colour_area = 'CDEB8B'; $colour_area_max = 'cc9999'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Processes'; diff --git a/includes/html/graphs/device/hr_users.inc.php b/includes/html/graphs/device/hr_users.inc.php index 86130d01ee..9703b4e2a1 100644 --- a/includes/html/graphs/device/hr_users.inc.php +++ b/includes/html/graphs/device/hr_users.inc.php @@ -12,7 +12,6 @@ $colour_area = 'CDEB8B'; $colour_area_max = 'cc9999'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Users'; diff --git a/includes/html/graphs/device/routeros_leases.inc.php b/includes/html/graphs/device/routeros_leases.inc.php index a51f4dafb2..eaffe4452f 100644 --- a/includes/html/graphs/device/routeros_leases.inc.php +++ b/includes/html/graphs/device/routeros_leases.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $scale_min = '0'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Leases'; diff --git a/includes/html/graphs/device/routeros_pppoe_sessions.inc.php b/includes/html/graphs/device/routeros_pppoe_sessions.inc.php index 84728d53ae..6ae5ea1036 100644 --- a/includes/html/graphs/device/routeros_pppoe_sessions.inc.php +++ b/includes/html/graphs/device/routeros_pppoe_sessions.inc.php @@ -12,7 +12,6 @@ $colour_line = '00cc00'; $colour_area_max = '99cc99'; $scale_min = '0'; $graph_max = 1; -$graph_min = 0; $unit_text = 'PPPoE Sessions'; diff --git a/includes/html/graphs/device/sgos_average_requests.inc.php b/includes/html/graphs/device/sgos_average_requests.inc.php index 6676999244..d880054e6b 100644 --- a/includes/html/graphs/device/sgos_average_requests.inc.php +++ b/includes/html/graphs/device/sgos_average_requests.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Requests'; diff --git a/includes/html/graphs/device/topvision_cmoffline.inc.php b/includes/html/graphs/device/topvision_cmoffline.inc.php index d9c6b673e6..cfb11e05f2 100644 --- a/includes/html/graphs/device/topvision_cmoffline.inc.php +++ b/includes/html/graphs/device/topvision_cmoffline.inc.php @@ -11,7 +11,6 @@ $colour_area_max = '9999cc'; $scale_min = '0'; $graph_max = 1; -$graph_min = 0; $unit_text = 'CM Offline'; diff --git a/includes/html/graphs/device/topvision_cmreg.inc.php b/includes/html/graphs/device/topvision_cmreg.inc.php index e3fe02f6ab..661978be10 100644 --- a/includes/html/graphs/device/topvision_cmreg.inc.php +++ b/includes/html/graphs/device/topvision_cmreg.inc.php @@ -11,7 +11,6 @@ $colour_area_max = '9999cc'; $scale_min = '0'; $graph_max = 1; -$graph_min = 0; $unit_text = 'CM Registered'; diff --git a/includes/html/graphs/device/topvision_cmtotal.inc.php b/includes/html/graphs/device/topvision_cmtotal.inc.php index a2b2a328c4..de852f2d5b 100644 --- a/includes/html/graphs/device/topvision_cmtotal.inc.php +++ b/includes/html/graphs/device/topvision_cmtotal.inc.php @@ -11,7 +11,6 @@ $colour_area_max = '9999cc'; $scale_min = '0'; $graph_max = 1; -$graph_min = 0; $unit_text = 'CM Total'; diff --git a/includes/html/graphs/device/waas_cwotfostatsactiveoptconn.inc.php b/includes/html/graphs/device/waas_cwotfostatsactiveoptconn.inc.php index a9d17522cf..7c4c0c63d9 100644 --- a/includes/html/graphs/device/waas_cwotfostatsactiveoptconn.inc.php +++ b/includes/html/graphs/device/waas_cwotfostatsactiveoptconn.inc.php @@ -12,7 +12,6 @@ $colour_line = '0000cc'; $colour_area_max = '9999cc'; $graph_max = 1; -$graph_min = 0; $unit_text = 'Optimized TCP Connections';