From 335a2383493e304458112bb60afa66365032a661 Mon Sep 17 00:00:00 2001
From: SourceDoctor <sourcehhdoctor@googlemail.com>
Date: Sat, 29 Feb 2020 22:53:17 +0100
Subject: [PATCH] Open Links to external Urls (Docs) in new tab (#11227)

* Open Links to external Urls (Docs) in new tab
---
 includes/html/modal/alert_template.inc.php    |  2 +-
 .../html/modal/edit_alert_transport.inc.php   |  2 +-
 .../html/modal/edit_transport_group.inc.php   |  2 +-
 includes/html/modal/new_alert_rule.inc.php    |  2 +-
 includes/html/modal/new_customoid.inc.php     |  2 +-
 resources/views/about/index.blade.php         | 20 +++++++++----------
 .../views/errors/static/file_permissions.html |  2 +-
 resources/views/layouts/error.blade.php       |  2 +-
 8 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/includes/html/modal/alert_template.inc.php b/includes/html/modal/alert_template.inc.php
index b8b2631121..344919ad70 100644
--- a/includes/html/modal/alert_template.inc.php
+++ b/includes/html/modal/alert_template.inc.php
@@ -22,7 +22,7 @@ if (!Auth::user()->hasGlobalAdmin()) {
         <div class="modal-content">
             <div class="modal-header">
                 <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-                <h4 class="modal-title" id="Create">Alert Template :: <a href="https://docs.librenms.org/Alerting/Templates/"><i class="fa fa-book fa-1x"></i> Docs</a></h4>
+                <h4 class="modal-title" id="Create">Alert Template :: <a target="_blank" href="https://docs.librenms.org/Alerting/Templates/"><i class="fa fa-book fa-1x"></i> Docs</a></h4>
             </div>
             <div class="modal-body">
                 <div class="row">
diff --git a/includes/html/modal/edit_alert_transport.inc.php b/includes/html/modal/edit_alert_transport.inc.php
index 2105286418..5eb5018a3f 100644
--- a/includes/html/modal/edit_alert_transport.inc.php
+++ b/includes/html/modal/edit_alert_transport.inc.php
@@ -22,7 +22,7 @@ if (Auth::user()->hasGlobalAdmin()) {
             <div class="modal-content">
                 <div class="modal-header">
                     <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-                    <h5 class="modal-title" id="Edit-transport">Alert Transport :: <a href="https://docs.librenms.org/Alerting/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
+                    <h5 class="modal-title" id="Edit-transport">Alert Transport :: <a target="_blank" href="https://docs.librenms.org/Alerting/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
                 </div>
                 <div class="modal-body">
                     <form method="post" role="form" id="transports" class="form-horizontal transports-form">
diff --git a/includes/html/modal/edit_transport_group.inc.php b/includes/html/modal/edit_transport_group.inc.php
index 65d6ba0894..70d09833d1 100644
--- a/includes/html/modal/edit_transport_group.inc.php
+++ b/includes/html/modal/edit_transport_group.inc.php
@@ -20,7 +20,7 @@ if (Auth::user()->hasGlobalAdmin()) {
             <div class="modal-content">
                 <div class="modal-header">
                     <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-                    <h5 class="modal-title" id="Edit-transport">Alert Transport Groups :: <a href="https://docs.librenms.org/Alerting/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
+                    <h5 class="modal-title" id="Edit-transport">Alert Transport Groups :: <a target="_blank" href="https://docs.librenms.org/Alerting/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
                 </div>
                 <div class="modal-body">
                     <form method="post" role="form" id="transport-group" class="form-horizontal transport-group-form">
diff --git a/includes/html/modal/new_alert_rule.inc.php b/includes/html/modal/new_alert_rule.inc.php
index d256c0013d..26e9740d01 100644
--- a/includes/html/modal/new_alert_rule.inc.php
+++ b/includes/html/modal/new_alert_rule.inc.php
@@ -35,7 +35,7 @@ if (Auth::user()->hasGlobalAdmin()) {
             <div class="modal-content">
                 <div class="modal-header">
                     <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-                    <h5 class="modal-title" id="Create">Alert Rule :: <a href="https://docs.librenms.org/Alerting/"><i class="fa fa-book fa-1x"></i> Docs</a> </h5>
+                    <h5 class="modal-title" id="Create">Alert Rule :: <a target="_blank" href="https://docs.librenms.org/Alerting/"><i class="fa fa-book fa-1x"></i> Docs</a> </h5>
                 </div>
                 <div class="modal-body">
                     <ul class="nav nav-tabs" role="tablist">
diff --git a/includes/html/modal/new_customoid.inc.php b/includes/html/modal/new_customoid.inc.php
index bcfc93c62e..74957ac2b2 100644
--- a/includes/html/modal/new_customoid.inc.php
+++ b/includes/html/modal/new_customoid.inc.php
@@ -11,7 +11,7 @@ if (!(Auth::user()->hasGlobalAdmin())) {
         <div class="modal-content">
             <div class="modal-header">
                 <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-                <h5 class="modal-title" id="Create">Custom OID :: <a href="https://docs.librenms.org/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
+                <h5 class="modal-title" id="Create">Custom OID :: <a target="_blank" href="https://docs.librenms.org/">Docs <i class="fa fa-book fa-1x"></i></a> </h5>
             </div>
             <div class="modal-body">
                 <form method="post" role="form" id="coids" class="form-horizontal coid_form">
diff --git a/resources/views/about/index.blade.php b/resources/views/about/index.blade.php
index 7b9ed054c8..a3f33db52f 100644
--- a/resources/views/about/index.blade.php
+++ b/resources/views/about/index.blade.php
@@ -28,7 +28,7 @@
             <table class='table table-condensed table-hover'>
                 <tr>
                     <td><b>@lang('Version')</b></td>
-                    <td><a href='http://www.librenms.org/changelog.html'>{{ $version_local }}<span id='version_date' style="display: none;">{{ $git_date }}</span></a></td>
+                    <td><a target="_blank" href='http://www.librenms.org/changelog.html'>{{ $version_local }}<span id='version_date' style="display: none;">{{ $git_date }}</span></a></td>
                 </tr>
                 <tr>
                     <td><b>@lang('Database Schema')</b></td>
@@ -56,13 +56,13 @@
             <h3>@lang('LibreNMS is a community-based project')</h3>
             @lang('Please feel free to join us and contribute code, documentation, and bug reports:')
             <br>
-              <a href="http://www.librenms.org/">@lang('Web site')</a> |
-              <a href="https://docs.librenms.org/">@lang('Docs')</a> |
-              <a href="https://github.com/librenms/">@lang('GitHub')</a> |
-              <a href="https://community.librenms.org/c/help">@lang('Bug tracker')</a> |
-              <a href="https://community.librenms.org">@lang('Community Forum')</a> |
-              <a href="http://twitter.com/librenms">@lang('Twitter')</a> |
-              <a href="http://www.librenms.org/changelog.html">@lang('Changelog')</a> |
+              <a target="_blank" href="http://www.librenms.org/">@lang('Web site')</a> |
+              <a target="_blank" href="https://docs.librenms.org/">@lang('Docs')</a> |
+              <a target="_blank" href="https://github.com/librenms/">@lang('GitHub')</a> |
+              <a target="_blank" href="https://community.librenms.org/c/help">@lang('Bug tracker')</a> |
+              <a target="_blank" href="https://community.librenms.org">@lang('Community Forum')</a> |
+              <a target="_blank" href="http://twitter.com/librenms">@lang('Twitter')</a> |
+              <a target="_blank" href="http://www.librenms.org/changelog.html">@lang('Changelog')</a> |
               <a href="#" data-toggle="modal" data-target="#git_log">@lang('Local git log')</a>
           </p>
 
@@ -94,7 +94,7 @@
                     </span>
                     <input type="checkbox" id="callback" data-size="normal" name="statistics" @if($callback_status) checked @endif>
                     <br />
-                    @lang('Online stats:') <a href='https://stats.librenms.org/'>stats.librenms.org</a>
+                    @lang('Online stats:') <a target="_blank" href='https://stats.librenms.org/'>stats.librenms.org</a>
                 </td>
             </tr>
 
@@ -185,7 +185,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 
 You should have received a copy of the GNU General Public License
-along with this program.  If not, see <a href="http://www.gnu.org/licenses/">http://www.gnu.org/licenses/</a>.</pre>
+along with this program.  If not, see <a target="_blank" href="http://www.gnu.org/licenses/">http://www.gnu.org/licenses/</a>.</pre>
 
         </div>
     </div>
diff --git a/resources/views/errors/static/file_permissions.html b/resources/views/errors/static/file_permissions.html
index 444a03f407..b9ab7253cf 100644
--- a/resources/views/errors/static/file_permissions.html
+++ b/resources/views/errors/static/file_permissions.html
@@ -72,7 +72,7 @@
     <hr class="separator"/>
     <p>Check your log for more details.  (<i>!!!!LOG_FILE!!!!</i>)</p>
 
-    <p>If that doesn't fix the issue. You can find how to get help at <a href="https://docs.librenms.org/Support">https://docs.librenms.org/Support</a>.</p>
+    <p>If that doesn't fix the issue. You can find how to get help at <a target="_blank" href="https://docs.librenms.org/Support">https://docs.librenms.org/Support</a>.</p>
 </div>
 
 </body>
diff --git a/resources/views/layouts/error.blade.php b/resources/views/layouts/error.blade.php
index 8362cd283b..c0728a801e 100644
--- a/resources/views/layouts/error.blade.php
+++ b/resources/views/layouts/error.blade.php
@@ -70,7 +70,7 @@
     <hr class="separator"/>
     <p>@lang("Check your log for more details.") ({{ isset($log_file) ? $log_file : 'librenms.log' }})</p>
 
-    <p>@lang("If you need additional help, you can find how to get help at") <a href="https://docs.librenms.org/Support">https://docs.librenms.org/Support</a>.</p>
+    <p>@lang("If you need additional help, you can find how to get help at") <a target="_blank" href="https://docs.librenms.org/Support">https://docs.librenms.org/Support</a>.</p>
 </div>
 </body>
 </html>