mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
Security fix: unauthorized access (#10091)
* Security fix: unauthorized access Affects nginx users: Moved php files outside of public html directory (Apache was protected by .htaccess) Affects all users: Some files did not check for authentication and could disclose some info. Better checks before including files from user input * git mv html/includes/ includes/html git mv html/pages/ includes/html/
This commit is contained in:
55
includes/html/forms/sensor-update.inc.php
Normal file
55
includes/html/forms/sensor-update.inc.php
Normal file
@@ -0,0 +1,55 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* LibreNMS
|
||||
*
|
||||
* Copyright (c) 2014 Neil Lathwood <https://github.com/laf/ http://www.lathwood.co.uk>
|
||||
* Copyright (c) 2018 TheGreatDoc <https://github.com/TheGreatDoc>
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License as published by the
|
||||
* Free Software Foundation, either version 3 of the License, or (at your
|
||||
* option) any later version. Please see LICENSE.txt at the top level of
|
||||
* the source code distribution for details.
|
||||
*/
|
||||
|
||||
use LibreNMS\Authentication\LegacyAuth;
|
||||
|
||||
header('Content-type: application/json');
|
||||
|
||||
if (!LegacyAuth::user()->hasGlobalAdmin()) {
|
||||
$response = array(
|
||||
'status' => 'error',
|
||||
'message' => 'Need to be admin',
|
||||
);
|
||||
echo _json_encode($response);
|
||||
exit;
|
||||
}
|
||||
|
||||
$status = 'error';
|
||||
$message = 'Error updating sensor limit';
|
||||
$device_id = $_POST['device_id'];
|
||||
$sensor_id = $_POST['sensor_id'];
|
||||
$value_type = $_POST['value_type'];
|
||||
$data = $_POST['data'];
|
||||
|
||||
if (!is_numeric($device_id)) {
|
||||
$message = 'Missing device id';
|
||||
} elseif (!is_numeric($sensor_id)) {
|
||||
$message = 'Missing sensor id';
|
||||
} elseif (!isset($data)) {
|
||||
$message = 'Missing data';
|
||||
} else {
|
||||
if (dbUpdate(array($value_type => set_null($data, array('NULL')), 'sensor_custom' => 'Yes'), 'sensors', '`sensor_id` = ? AND `device_id` = ?', array($sensor_id, $device_id)) >= 0) {
|
||||
$message = 'Sensor value updated';
|
||||
$status = 'ok';
|
||||
} else {
|
||||
$message = 'Could not update sensor value';
|
||||
}
|
||||
}
|
||||
|
||||
$response = array(
|
||||
'status' => $status,
|
||||
'message' => $message,
|
||||
);
|
||||
echo _json_encode($response);
|
||||
Reference in New Issue
Block a user