mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
Security fix: unauthorized access (#10091)
* Security fix: unauthorized access Affects nginx users: Moved php files outside of public html directory (Apache was protected by .htaccess) Affects all users: Some files did not check for authentication and could disclose some info. Better checks before including files from user input * git mv html/includes/ includes/html git mv html/pages/ includes/html/
This commit is contained in:
65
includes/html/forms/sql-from-alert-collection.inc.php
Normal file
65
includes/html/forms/sql-from-alert-collection.inc.php
Normal file
@@ -0,0 +1,65 @@
|
||||
<?php
|
||||
/**
|
||||
* alert-rules.inc.php
|
||||
*
|
||||
* LibreNMS alert-rules.inc.php for processor
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
* @package LibreNMS
|
||||
* @link http://librenms.org
|
||||
* @copyright 2018 Neil Lathwood
|
||||
* @author Neil Lathwood <gh+n@laf.io>
|
||||
*/
|
||||
|
||||
use LibreNMS\Alerting\QueryBuilderParser;
|
||||
use LibreNMS\Authentication\LegacyAuth;
|
||||
|
||||
header('Content-type: application/json');
|
||||
|
||||
if (!LegacyAuth::user()->hasGlobalAdmin()) {
|
||||
die(json_encode([
|
||||
'status' => 'error',
|
||||
'message' => 'ERROR: You need to be admin',
|
||||
]));
|
||||
}
|
||||
|
||||
$template_id = $vars['template_id'];
|
||||
|
||||
if (is_numeric($template_id)) {
|
||||
$rules = get_rules_from_json();
|
||||
$rule = $rules[$template_id];
|
||||
$default_extra = [
|
||||
'mute' => false,
|
||||
'count' => '-1',
|
||||
'delay' => 60,
|
||||
'invert' => false,
|
||||
'interval' => 300,
|
||||
'recovery' => true,
|
||||
];
|
||||
$output = [
|
||||
'status' => 'ok',
|
||||
'name' => $rule['name'],
|
||||
'builder' => $rule['builder'] ?: QueryBuilderParser::fromOld($rule['rule'])->toArray(),
|
||||
'extra' => array_replace($default_extra, (array)$rule['extra']),
|
||||
'severity' => $rule['severity'] ?: 'critical'
|
||||
];
|
||||
} else {
|
||||
$output = [
|
||||
'status' => 'error',
|
||||
'message' => 'Invalid template'
|
||||
];
|
||||
}
|
||||
|
||||
die(json_encode($output));
|
Reference in New Issue
Block a user