mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
includes/html/graphs/atmvp/auth.inc.php Normal file
View File

@@ -0,0 +1,17 @@
<?php
if ($_GET['id'] && is_numeric($_GET['id'])) {
$atm_vp_id = $_GET['id'];
}
$vp = dbFetchRow('SELECT * FROM `juniAtmVp` as J, `ports` AS I, `devices` AS D WHERE J.juniAtmVp_id = ? AND I.port_id = J.port_id AND I.device_id = D.device_id', array($atm_vp_id));
if ($auth || port_permitted($vp['port_id'])) {
$port = cleanPort($vp);
$device = device_by_id_cache($port['device_id']);
$title = generate_device_link($device);
$title .= ' :: Port '.generate_port_link($port);
$title .= ' :: VP '.$vp['vp_id'];
$auth = true;
$rrd_filename = rrd_name($vp['hostname'], array('vp', $vp['ifIndex'], $vp['vp_id']));
}

6
includes/html/graphs/atmvp/bits.inc.php Normal file
View File

@@ -0,0 +1,6 @@
<?php
$ds_in = 'inpacketoctets';
$ds_out = 'outpacketoctets';
require 'includes/html/graphs/generic_data.inc.php';

17
includes/html/graphs/atmvp/cells.inc.php Normal file
View File

@@ -0,0 +1,17 @@
<?php
$ds_in = 'incells';
$ds_out = 'outcells';
$colour_area_in = 'AA66AA';
$colour_line_in = '330033';
$colour_area_out = 'FFDD88';
$colour_line_out = 'FF6600';
$colour_area_in_max = 'cc88cc';
$colour_area_out_max = 'FFefaa';
$graph_max = 1;
$unit_text = 'Cells';
require 'includes/html/graphs/generic_duplex.inc.php';

18
includes/html/graphs/atmvp/errors.inc.php Normal file
View File

@@ -0,0 +1,18 @@
<?php
$ds_in = 'inpacketerrors';
$ds_out = 'outpacketerrors';
$colour_area_in = 'FF3300';
$colour_line_in = 'FF0000';
$colour_area_out = 'FF6633';
$colour_line_out = 'CC3300';
$colour_area_in_max = 'FF6633';
$colour_area_out_max = 'FF9966';
$graph_max = 1;
$unit_text = 'Errors';
require 'includes/html/graphs/generic_duplex.inc.php';

17
includes/html/graphs/atmvp/packets.inc.php Normal file
View File

@@ -0,0 +1,17 @@
<?php
$ds_in = 'inpackets';
$ds_out = 'outpackets';
$colour_area_in = 'AA66AA';
$colour_line_in = '330033';
$colour_area_out = 'FFDD88';
$colour_line_out = 'FF6600';
$colour_area_in_max = 'CC88CC';
$colour_area_out_max = 'FFEFAA';
$graph_max = 1;
$unit_text = 'Packets';
require 'includes/html/graphs/generic_duplex.inc.php';