mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
includes/html/graphs/port/auth.inc.php Normal file
View File

@@ -0,0 +1,19 @@
<?php
if (is_numeric($vars['id']) && ($auth || port_permitted($vars['id']))) {
$port = cleanPort(get_port_by_id($vars['id']));
$device = device_by_id_cache($port['device_id']);
$title = generate_device_link($device);
$title .= ' :: Port '.generate_port_link($port);
$graph_title = shorthost($device['hostname']).'::'.strtolower(makeshortif($port['ifDescr']));
if (($port['ifAlias'] != '') && ($port['ifAlias'] != $port['ifDescr'])) {
$title .= ', '.display($port['ifAlias']);
$graph_title .= '::'.display($port['ifAlias']);
}
$auth = true;
$rrd_filename = get_port_rrdfile_path($device['hostname'], $port['port_id']);
}