mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
includes/html/graphs/service/auth.inc.php Normal file
View File

@@ -0,0 +1,16 @@
<?php
if (is_numeric($vars['id'])) {
$service = dbFetchRow('SELECT * FROM services WHERE service_id = ?', array($vars['id']));
if (is_numeric($service['device_id']) && ($auth || device_permitted($service['device_id']))) {
$device = device_by_id_cache($service['device_id']);
// This doesn't quite work for all yet.
$rrd_filename = rrd_name($device['hostname'], array('service', $service['service_type'], $service['service_id']));
$title = generate_device_link($device);
$title .= ' :: Service :: '.htmlentities($service['service_type']);
$auth = true;
}
}

21
includes/html/graphs/service/availability.inc.php Normal file
View File

@@ -0,0 +1,21 @@
<?php
$scale_min = '0';
$scale_max = '1';
require 'includes/html/graphs/common.inc.php';
$service_text = substr(str_pad($service['service_type'], 28), 0, 28);
$rrd_options .= " COMMENT:' Cur Avail\\n'";
$rrd_options .= " DEF:status=$rrd_filename:status:AVERAGE";
$rrd_options .= ' CDEF:percent=status,100,*';
$rrd_options .= ' CDEF:down=status,1,LT,status,UNKN,IF';
$rrd_options .= ' CDEF:percentdown=down,100,*';
$rrd_options .= ' AREA:percent#CCFFCC';
$rrd_options .= ' AREA:percentdown#FFCCCC';
$rrd_options .= " LINE1.5:percent#009900:'".$service_text."'";
// Ugly hack :(
$rrd_options .= ' LINE1.5:percentdown#cc0000';
$rrd_options .= ' GPRINT:status:LAST:%3.0lf';
$rrd_options .= ' GPRINT:percent:AVERAGE:%3.5lf%%\l';