mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
includes/html/graphs/storage/auth.inc.php Normal file
View File

@@ -0,0 +1,14 @@
<?php
if (is_numeric($vars['id'])) {
$storage = dbFetchRow('SELECT * FROM `storage` WHERE `storage_id` = ?', array($vars['id']));
if (is_numeric($storage['device_id']) && ($auth || device_permitted($storage['device_id']))) {
$device = device_by_id_cache($storage['device_id']);
$rrd_filename = rrd_name($device['hostname'], array('storage', $storage['storage_mib'], $storage['storage_descr']));
$title = generate_device_link($device);
$title .= ' :: Storage :: '.htmlentities($storage['storage_descr']);
$auth = true;
}
}