mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
includes/html/graphs/wireless/wireless-sensor.inc.php Normal file
View File

@@ -0,0 +1,82 @@
<?php
/**
* wireless-sensor.inc.php
*
* Common file for Wireless Sensor Graphs
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* @package LibreNMS
* @link http://librenms.org
* @copyright 2017 Tony Murray
* @author Tony Murray <murraytony@gmail.com>
*/
require 'includes/html/graphs/common.inc.php';
// escape % characters
$unit = preg_replace('/(?<!%)%(?!%)/', '%%', $unit);
if ($unit_long == $sensor['sensor_descr']) {
$unit_long = '';
}
$col_w = 7 + strlen($unit);
$sensor_descr_fixed = rrdtool_escape($sensor['sensor_descr'], 28);
$rrd_options .= " COMMENT:'". str_pad($unit_long, 35) . str_pad("Cur", $col_w). str_pad("Min", $col_w) . "Max\\n'";
$rrd_options .= " DEF:sensor=$rrd_filename:sensor:AVERAGE";
$num = '%5.2lf'; // default: float
$output_def = 'sensor';
$factor = 1;
if ($unit === '') {
$num = '%5.0lf';
} elseif ($unit == 'bps') {
$num = '%5.3lf%s';
} elseif ($unit == 'Hz') {
$num = '%5.3lf%s';
$factor = 1000000;
$output_def = 'sensorhz';
$rrd_options .= " CDEF:$output_def=sensor,$factor,*";
} elseif ($unit == 'm') {
$num = '%5.3lf%s';
$factor = 1000;
$output_def = 'sensorm';
$rrd_options .= " CDEF:$output_def=sensor,$factor,*";
}
$rrd_options .= " LINE1.5:$output_def#0000cc:'$sensor_descr_fixed'";
if (isset($scale_min) && $scale_min >= 0) {
$rrd_options .= " AREA:$output_def#0000cc55";
}
// ---- limits ----
if ($vars['width'] > 300) {
if (is_numeric($sensor['sensor_limit'])) {
$rrd_options .= ' LINE1:'.$sensor['sensor_limit']*$factor.'#cc000060::dashes';
}
if (is_numeric($sensor['sensor_limit_low'])) {
$rrd_options .= ' LINE1:'.$sensor['sensor_limit_low']*$factor.'#cc000060::dashes';
}
}
// ---- legend ----
$rrd_options .= " GPRINT:$output_def:LAST:'$num$unit'";
$rrd_options .= " GPRINT:$output_def:MIN:'$num$unit'";
$rrd_options .= " GPRINT:$output_def:MAX:'$num$unit'\\l";