mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security fix: unauthorized access (#10091)

Browse Source 
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
This commit is contained in:
Tony Murray
2019-04-11 23:26:42 -05:00
committed by GitHub
parent b81af32ed2
commit 36431dd296
1301 changed files with 1443 additions and 1439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
includes/html/pages/device/apps.inc.php Normal file
View File

@@ -0,0 +1,59 @@
<?php
print_optionbar_start();
echo "<span style='font-weight: bold;'>Apps</span> &#187; ";
unset($sep);
$link_array = array(
'page' => 'device',
'device' => $device['device_id'],
'tab' => 'apps',
);
foreach (dbFetchRows('SELECT * FROM `applications` WHERE `device_id` = ?', array($device['device_id'])) as $app) {
echo $sep;
if (!$vars['app']) {
$vars['app'] = $app['app_type'];
}
if ($vars['app'] == $app['app_type']) {
echo "<span class='pagemenu-selected'>";
} else {
}
$link_add = array('app' => $app['app_type']);
$text = nicecase($app['app_type']);
if (!empty($app['app_instance'])) {
$text .= '('.$app['app_instance'].')';
$link_add['instance'] = $app['app_id'];
}
echo generate_link($text, $link_array, $link_add);
if ($vars['app'] == $app['app_type']) {
echo '</span>';
}
$sep = ' | ';
}
print_optionbar_end();
$where_array = array(
$device['device_id'],
$vars['app'],
);
if ($vars['instance']) {
$where = ' AND `app_id` = ?';
$where_array[] = $vars['instance'];
}
$app = dbFetchRow('SELECT * FROM `applications` WHERE `device_id` = ? AND `app_type` = ?'.$where, $where_array);
if (is_file('includes/html/pages/device/apps/'.mres($vars['app']).'.inc.php')) {
include 'includes/html/pages/device/apps/'.mres($vars['app']).'.inc.php';
}
$pagetitle[] = 'Apps';