mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
Security fix: unauthorized access (#10091)
* Security fix: unauthorized access Affects nginx users: Moved php files outside of public html directory (Apache was protected by .htaccess) Affects all users: Some files did not check for authentication and could disclose some info. Better checks before including files from user input * git mv html/includes/ includes/html git mv html/pages/ includes/html/
This commit is contained in:
47
includes/html/vars.inc.php
Normal file
47
includes/html/vars.inc.php
Normal file
@@ -0,0 +1,47 @@
|
||||
<?php
|
||||
|
||||
use LibreNMS\Config;
|
||||
|
||||
foreach ($_GET as $key => $get_var) {
|
||||
if (strstr($key, 'opt')) {
|
||||
list($name, $value) = explode('|', $get_var);
|
||||
if (!isset($value)) {
|
||||
$value = 'yes';
|
||||
}
|
||||
|
||||
$vars[$name] = clean($value);
|
||||
}
|
||||
}
|
||||
|
||||
$base_url = parse_url(Config::get('base_url'));
|
||||
// don't parse the subdirectory, if there is one in the path
|
||||
if (isset($base_url['path']) && strlen($base_url['path']) > 1) {
|
||||
$segments = explode('/', trim(str_replace($base_url["path"], "", $_SERVER['REQUEST_URI']), '/'));
|
||||
} else {
|
||||
$segments = explode('/', trim($_SERVER['REQUEST_URI'], '/'));
|
||||
}
|
||||
|
||||
foreach ($segments as $pos => $segment) {
|
||||
$segment = urldecode($segment);
|
||||
if ($pos == '0') {
|
||||
$vars['page'] = $segment;
|
||||
} else {
|
||||
list($name, $value) = explode('=', $segment);
|
||||
if ($value == '' || !isset($value)) {
|
||||
$vars[$name] = 'yes';
|
||||
} else {
|
||||
$vars[$name] = $value;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
foreach ($_GET as $name => $value) {
|
||||
$vars[$name] = clean($value);
|
||||
}
|
||||
|
||||
foreach ($_POST as $name => $value) {
|
||||
$vars[$name] = ($value);
|
||||
}
|
||||
|
||||
// don't leak login data
|
||||
unset($vars['username'], $vars['password']);
|
||||
Reference in New Issue
Block a user