mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Oxidized list now checks device permission based on user (#9331)

Browse Source 
* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS

* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS (CodeClimate)
This commit is contained in:
PipoCanaja
2018-10-17 18:12:25 +02:00
committed by Neil Lathwood
parent 8005619e62
commit 417e518ae2
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
html/includes/functions.inc.php
View File

@ -1512,11 +1512,19 @@ function get_oxidized_nodes_list()
foreach ($data as $object) {
$device = device_by_name($object['name']);
if (! device_permitted($device['device_id'])) {
//user cannot see this device, so let's skip it.
continue;
}
$fa_color = $object['status'] == 'success' ? 'success' : 'danger';
echo "
<tr>
<td>
" . generate_device_link($device) . "
" . generate_device_link($device);
if ($device['device_id'] == 0) {
echo "(device '" . $object['name'] . "' not in LibreNMS)";
}
echo "
</td>
<td>
<i class='fa fa-square text-" . $fa_color . "'></i>
@ -1531,12 +1539,23 @@ function get_oxidized_nodes_list()
" . $object['group'] . "
</td>
<td>
";
if (! $device['device_id'] == 0) {
echo "
<button class='btn btn-default btn-sm' name='btn-refresh-node-devId" . $device['device_id'] . "' id='btn-refresh-node-devId" . $device['device_id'] . "' onclick='refresh_oxidized_node(\"" . $device['hostname'] . "\")'>
<i class='fa fa-refresh'></i>
</button>
<a href='" . generate_url(array('page' => 'device', 'device' => $device['device_id'], 'tab' => 'showconfig')) . "'>
<i class='fa fa-align-justify fa-lg icon-theme'></i>
</a>
";
} else {
echo "
<button class='btn btn-default btn-sm' disabled name='btn-refresh-node-devId" . $device['device_id'] . "' id='btn-refresh-node-devId" . $device['device_id'] . "'>
<i class='fa fa-refresh'></i>
</button>";
}
echo "
</td>
</tr>";
}