From 5126fd06fa2f2b4fbe86d90862ce6de3215e299d Mon Sep 17 00:00:00 2001 From: Zmegolaz Date: Fri, 3 Nov 2017 11:00:27 +0100 Subject: [PATCH] Better sanity checks of fping options. --- includes/functions.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/functions.php b/includes/functions.php index ac24c9e24f..5a5dfe50f5 100644 --- a/includes/functions.php +++ b/includes/functions.php @@ -661,16 +661,16 @@ function isPingable($hostname, $address_family = AF_INET, $attribs = array()) $response = array(); if (can_ping_device($attribs) === true) { $fping_params = ''; - if (is_numeric($config['fping_options']['retries']) || $config['fping_options']['retries'] > 1) { + if (is_numeric($config['fping_options']['retries']) && $config['fping_options']['retries'] > 0 && $config['fping_options']['retries'] <= 20) { $fping_params .= ' -r ' . $config['fping_options']['retries']; } - if (is_numeric($config['fping_options']['timeout']) || $config['fping_options']['timeout'] > 1) { + if (is_numeric($config['fping_options']['timeout']) && $config['fping_options']['timeout'] > 50) { $fping_params .= ' -t ' . $config['fping_options']['timeout']; } - if (is_numeric($config['fping_options']['count']) || $config['fping_options']['count'] > 0) { + if (is_numeric($config['fping_options']['count']) && $config['fping_options']['count'] > 0) { $fping_params .= ' -c ' . $config['fping_options']['count']; } - if (is_numeric($config['fping_options']['millisec']) || $config['fping_options']['millisec'] > 0) { + if (is_numeric($config['fping_options']['millisec']) && $config['fping_options']['millisec'] > 20) { $fping_params .= ' -p ' . $config['fping_options']['millisec']; } $status = fping($hostname, $fping_params, $address_family);