mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor SnmpResponse mapTable (#16238)

Browse Source 
Replace previous code with a couple of foreach loops
This commit is contained in:
Tony Murray
2024-07-22 21:23:10 -05:00
committed by GitHub
parent 7c8276052e
commit 55f603c30c
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
LibreNMS/Data/Source/SnmpResponse.php
View File

@@ -216,23 +216,19 @@ class SnmpResponse
return new Collection; return new Collection;
} }
return collect($this->values()) $data = [];
->map(function ($value, $oid) { foreach ($this->values() as $key => $value) {
$parts = $this->getOidParts($oid); $parts = $this->getOidParts($key);
$key = array_shift($parts); $oid = array_shift($parts);
$data[implode('][', $parts)][$oid] = $value;
}
return [ $return = new Collection;
'_index' => implode('][', $parts), foreach ($data as $index => $values) {
$key => $value, $return->push(call_user_func($callback, $values, ...explode('][', (string) $index)));
]; }
})
->groupBy('_index')
->map(function ($values, $index) use ($callback) {
$values = array_merge(...$values);
unset($values['_index']);
return call_user_func($callback, $values, ...explode('][', (string) $index)); return $return;
});
} }
/** /**