From 58442e0a75ced53b97019e721663ca90584ef2e6 Mon Sep 17 00:00:00 2001 From: Neil Lathwood Date: Wed, 8 Mar 2017 03:14:24 +0000 Subject: [PATCH] refactor: Further speed improvements to port poller (#6037) --- includes/polling/ports.inc.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/includes/polling/ports.inc.php b/includes/polling/ports.inc.php index a6a23e8f58..84c6defe68 100644 --- a/includes/polling/ports.inc.php +++ b/includes/polling/ports.inc.php @@ -181,17 +181,12 @@ if ($device['os'] === 'f5' && (version_compare($device['version'], '11.2.0', '>= } else { if ($config['polling']['selected_ports'] === true || $device['attribs']['selected_ports'] == 'true') { echo('Select ports polling'); - foreach ($table_base_oids as $oid) { - $data = snmpwalk_cache_oid($device, $oid, $data, 'IF-MIB'); - } - unset( - $oid, - $table_base_oids - ); $lports = dbFetchRows("SELECT * FROM `ports` where `device_id` = ? AND `deleted` = 0 AND `disabled` = 0", array($device['device_id'])); foreach ($lports as $lport) { if (is_port_valid($lport, $device)) { $i = $lport['ifIndex']; + $base_oids = implode(".$i ", $table_base_oids) . ".$i"; + $data = snmp_get_multi($device, $base_oids, '-OQUst', 'IF-MIB', null, $data); if ($lport['ifAdminStatus_prev'] === 'down' && $data[$i]['ifAdminStatus'] === 'down') { echo 'port is still admin down'; } elseif ($lport['ifOperStatus_prev'] === 'down' && $data[$i]['ifOperStatus'] === 'down') {