From 5872ccac1bd369bb898c1536f72620fbe41dcba9 Mon Sep 17 00:00:00 2001
From: Tom Laermans <tom@localhost>
Date: Thu, 22 Sep 2011 17:11:00 +0000
Subject: [PATCH] more url fixies, yay for generate_port_url

git-svn-id: http://www.observium.org/svn/observer/trunk@2547 61d68cd4-352d-0410-923a-c4978735b2b8
---
 html/includes/print-interface.inc.php | 4 ++--
 html/pages/device/ports.inc.php       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/html/includes/print-interface.inc.php b/html/includes/print-interface.inc.php
index 99374eaaff..df1dfb173b 100644
--- a/html/includes/print-interface.inc.php
+++ b/html/includes/print-interface.inc.php
@@ -25,10 +25,10 @@ if ($port['ifInErrors_delta'] > 0 || $port['ifOutErrors_delta'] > 0)
 
 if (dbFetchCell("SELECT COUNT(*) FROM `mac_accounting` WHERE `interface_id` = ?", array($port['interface_id'])))
 {
-  $mac = "<a href='device/".$port['device_id']."/port/".$port['interface_id']."/macaccounting/'><img src='/images/16/chart_curve.png' align='absmiddle'></a>";
+  $mac = "<a href='" . generate_port_url($port, array('view' => 'macaccounting')) . "'><img src='/images/16/chart_curve.png' align='absmiddle'></a>";
 } else { $mac = ""; }
 
-echo("<tr style=\"background-color: $row_colour;\" valign=top onmouseover=\"this.style.backgroundColor='$list_highlight';\" onmouseout=\"this.style.backgroundColor='$row_colour';\" onclick=\"location.href='device/".$device['device_id']."/port/".$port['interface_id']."/'\" style='cursor: pointer;'>
+echo("<tr style=\"background-color: $row_colour;\" valign=top onmouseover=\"this.style.backgroundColor='$list_highlight';\" onmouseout=\"this.style.backgroundColor='$row_colour';\" onclick=\"location.href='" . generate_port_url($port) . "/'\" style='cursor: pointer;'>
          <td valign=top width=350>");
 echo("        <span class=list-large>
               " . generate_port_link($port, $port['ifIndex'] . ". ".$port['label']) . " $error_img $mac
diff --git a/html/pages/device/ports.inc.php b/html/pages/device/ports.inc.php
index a406f5ebd3..9619a805de 100644
--- a/html/pages/device/ports.inc.php
+++ b/html/pages/device/ports.inc.php
@@ -64,7 +64,7 @@ foreach ($graph_types as $type => $descr)
 
 print_optionbar_end();
 
-if ($vars['view'] == minigraphs)
+if ($vars['view'] == 'minigraphs')
 {
   $timeperiods = array('-1day','-1week','-1month','-1year');
   $from = '-1day';
@@ -77,7 +77,7 @@ if ($vars['view'] == minigraphs)
   {
     echo("<div style='display: block; padding: 3px; margin: 3px; min-width: 183px; max-width:183px; min-height:90px; max-height:90px; text-align: center; float: left; background-color: #e9e9e9;'>
     <div style='font-weight: bold;'>".makeshortif($port['ifDescr'])."</div>
-    <a href='device/".$device['device_id']."/port/".$port['interface_id']."/' onmouseover=\"return overlib('\
+    <a href=\"" . generate_port_url($port) . "\" onmouseover=\"return overlib('\
     <div style=\'font-size: 16px; padding:5px; font-weight: bold; color: #e5e5e5;\'>".$device['hostname']." - ".$port['ifDescr']."</div>\
     ".$port['ifAlias']." \
     <img src=\'graph.php?type=".$graph_type."&amp;id=".$port['interface_id']."&amp;from=".$from."&amp;to=".$now."&amp;width=450&amp;height=150\'>\