Fix Air Fiber port stats (#11079)

* Fix Air Fiber port stats
Define OS port polling includes in a standard way.
Move Air Fiber code to os port polling include.

* Update snmp data

* fix accidental change

* Some formatting fixes

* should be null
This commit is contained in:
Tony Murray
2020-01-30 05:40:58 -06:00
committed by GitHub
parent 0a34322877
commit 67b28ec4cd
12 changed files with 116 additions and 77 deletions

View File

@@ -209,7 +209,7 @@ echo 'Caching Oids: ';
$port_stats = [];
if ($device['os'] === 'f5' && (version_compare($device['version'], '11.2.0', '>=') && version_compare($device['version'], '11.7', '<'))) {
require_once 'ports/f5.inc.php';
require 'ports/f5.inc.php';
} else {
if (Config::getOsSetting($device['os'], 'polling.selected_ports') || $device['attribs']['selected_ports'] == 'true') {
echo 'Selected ports polling ';
@@ -307,36 +307,9 @@ if ($device['os'] === 'f5' && (version_compare($device['version'], '11.2.0', '>=
}
}
if ($device['os'] == 'fabos') {
require_once 'ports/brocade.inc.php';
}
if ($device['os'] == 'procera') {
require_once 'ports/procera.inc.php';
}
if ($device['os'] == 'cxr-ts') {
require_once 'ports/cxr-ts.inc.php';
}
if ($device['os'] == 'cmm') {
require_once 'ports/cmm.inc.php';
}
if ($device['os'] == 'nokia-isam') {
require_once 'ports/nokia-isam.inc.php';
}
if ($device['os'] == 'timos') {
require_once 'ports/timos.inc.php';
}
if ($device['os'] == 'infinera-groove') {
require_once 'ports/infinera-groove.inc.php';
}
if ($device['os'] == 'junos') {
require_once 'ports/junos-vcp.inc.php';
$os_file = base_path("includes/polling/ports/os/{$device['os']}.inc.php");
if (file_exists($os_file)) {
require $os_file;
}
if (Config::get('enable_ports_adsl')) {
@@ -574,30 +547,6 @@ foreach ($ports as $port) {
$port['update']['ifIndex'] = $ifIndex;
}
if ($device['os'] === 'airos-af' && $port['ifAlias'] === 'eth0') {
$airos_stats = snmpwalk_cache_oid($device, '.1.3.6.1.4.1.41112.1.3.3.1', array(), 'UBNT-AirFIBER-MIB');
$this_port['ifInOctets'] = $airos_stats[1]['rxOctetsOK'];
$this_port['ifOutOctets'] = $airos_stats[1]['txOctetsOK'];
$this_port['ifInErrors'] = $airos_stats[1]['rxErroredFrames'];
$this_port['ifOutErrors'] = $airos_stats[1]['txErroredFrames'];
$this_port['ifInBroadcastPkts'] = $airos_stats[1]['rxValidBroadcastFrames'];
$this_port['ifOutBroadcastPkts'] = $airos_stats[1]['txValidBroadcastFrames'];
$this_port['ifInMulticastPkts'] = $airos_stats[1]['rxValidMulticastFrames'];
$this_port['ifOutMulticastPkts'] = $airos_stats[1]['txValidMulticastFrames'];
$this_port['ifInUcastPkts'] = $airos_stats[1]['rxValidUnicastFrames'];
$this_port['ifOutUcastPkts'] = $airos_stats[1]['txValidUnicastFrames'];
$ports['update']['ifInOctets'] = $airos_stats[1]['rxOctetsOK'];
$ports['update']['ifOutOctets'] = $airos_stats[1]['txOctetsOK'];
$ports['update']['ifInErrors'] = $airos_stats[1]['rxErroredFrames'];
$ports['update']['ifOutErrors'] = $airos_stats[1]['txErroredFrames'];
$ports['update']['ifInBroadcastPkts'] = $airos_stats[1]['rxValidBroadcastFrames'];
$ports['update']['ifOutBroadcastPkts'] = $airos_stats[1]['txValidBroadcastFrames'];
$ports['update']['ifInMulticastPkts'] = $airos_stats[1]['rxValidMulticastFrames'];
$ports['update']['ifOutMulticastPkts'] = $airos_stats[1]['txValidMulticastFrames'];
$ports['update']['ifInUcastPkts'] = $airos_stats[1]['rxValidUnicastFrames'];
$ports['update']['ifOutUcastPkts'] = $airos_stats[1]['txValidUnicastFrames'];
}
// rewrite the ifPhysAddress
if (strpos($this_port['ifPhysAddress'], ':')) {
list($a_a, $a_b, $a_c, $a_d, $a_e, $a_f) = explode(':', $this_port['ifPhysAddress']);

View File

@@ -0,0 +1,23 @@
<?php
$airos_stats = snmpwalk_cache_oid($device, '.1.3.6.1.4.1.41112.1.3.3.1', array(), 'UBNT-AirFIBER-MIB');
if (isset($airos_stats[1]['rxOctetsOK'])) {
foreach ($port_stats as $index => $afport_stats) {
if ($afport_stats['ifDescr'] == 'eth0') {
$port_stats[$index]['ifOperStatus'] = 'up'; // if may be marked as down
$port_stats[$index]['ifInOctets'] = $airos_stats[1]['rxOctetsOK'];
$port_stats[$index]['ifOutOctets'] = $airos_stats[1]['txOctetsOK'];
$port_stats[$index]['ifInErrors'] = $airos_stats[1]['rxErroredFrames'];
$port_stats[$index]['ifOutErrors'] = $airos_stats[1]['txErroredFrames'];
$port_stats[$index]['ifInBroadcastPkts'] = $airos_stats[1]['rxValidBroadcastFrames'];
$port_stats[$index]['ifOutBroadcastPkts'] = $airos_stats[1]['txValidBroadcastFrames'];
$port_stats[$index]['ifInMulticastPkts'] = $airos_stats[1]['rxValidMulticastFrames'];
$port_stats[$index]['ifOutMulticastPkts'] = $airos_stats[1]['txValidMulticastFrames'];
$port_stats[$index]['ifInUcastPkts'] = $airos_stats[1]['rxValidUnicastFrames'];
$port_stats[$index]['ifOutUcastPkts'] = $airos_stats[1]['txValidUnicastFrames'];
break;
}
}
}

View File

@@ -1,6 +1,6 @@
<?php
/**
* junos-vcp.inc.php
* junos.inc.php
*
* LibreNMS Junos VirtualChassis Ports include
*

View File

@@ -1349,7 +1349,7 @@
"ifConnectorPresent": null,
"ifPromiscuousMode": null,
"ifHighSpeed": null,
"ifOperStatus": "down",
"ifOperStatus": "up",
"ifOperStatus_prev": "down",
"ifAdminStatus": "up",
"ifAdminStatus_prev": null,
@@ -1357,7 +1357,7 @@
"ifMtu": 1500,
"ifType": "ethernetCsmacd",
"ifAlias": "eth0",
"ifPhysAddress": "788a20af3422",
"ifPhysAddress": "788a20af5643",
"ifHardType": null,
"ifLastChange": 0,
"ifVlan": "",
@@ -1378,27 +1378,27 @@
"pagpEthcOperationMode": null,
"pagpDeviceId": null,
"pagpGroupIfIndex": null,
"ifInUcastPkts": 0,
"ifInUcastPkts": 18006635030,
"ifInUcastPkts_prev": 0,
"ifInUcastPkts_delta": null,
"ifInUcastPkts_rate": null,
"ifOutUcastPkts": 0,
"ifOutUcastPkts": 11854374797,
"ifOutUcastPkts_prev": 0,
"ifOutUcastPkts_delta": null,
"ifOutUcastPkts_rate": null,
"ifInErrors": 0,
"ifInErrors": 55,
"ifInErrors_prev": 0,
"ifInErrors_delta": null,
"ifInErrors_rate": null,
"ifOutErrors": 0,
"ifOutErrors": 24,
"ifOutErrors_prev": 0,
"ifOutErrors_delta": null,
"ifOutErrors_rate": null,
"ifInOctets": 0,
"ifInOctets": 23669076995688,
"ifInOctets_prev": 0,
"ifInOctets_delta": null,
"ifInOctets_rate": null,
"ifOutOctets": 0,
"ifOutOctets": 1844894475537,
"ifOutOctets_prev": 0,
"ifOutOctets_delta": null,
"ifOutOctets_rate": null,
@@ -1423,19 +1423,19 @@
"ifInUnknownProtos_prev": 0,
"ifInUnknownProtos_delta": null,
"ifInUnknownProtos_rate": null,
"ifInBroadcastPkts": 0,
"ifInBroadcastPkts": 783281179,
"ifInBroadcastPkts_prev": 0,
"ifInBroadcastPkts_delta": null,
"ifInBroadcastPkts_rate": null,
"ifOutBroadcastPkts": 0,
"ifOutBroadcastPkts": 6399773,
"ifOutBroadcastPkts_prev": 0,
"ifOutBroadcastPkts_delta": null,
"ifOutBroadcastPkts_rate": null,
"ifInMulticastPkts": 0,
"ifInMulticastPkts": 256720305,
"ifInMulticastPkts_prev": 0,
"ifInMulticastPkts_delta": null,
"ifInMulticastPkts_rate": null,
"ifOutMulticastPkts": 0,
"ifOutMulticastPkts": 3064204,
"ifOutMulticastPkts_prev": 0,
"ifOutMulticastPkts_delta": null,
"ifOutMulticastPkts_rate": null
@@ -1462,7 +1462,7 @@
"ifMtu": 1500,
"ifType": "ethernetCsmacd",
"ifAlias": "air0",
"ifPhysAddress": "7a8a20af3422",
"ifPhysAddress": "7a8a20af5643",
"ifHardType": null,
"ifLastChange": 0,
"ifVlan": "",
@@ -1567,7 +1567,7 @@
"ifMtu": 1500,
"ifType": "ethernetCsmacd",
"ifAlias": "eth0.101",
"ifPhysAddress": "788a20af3422",
"ifPhysAddress": "788a20af5643",
"ifHardType": null,
"ifLastChange": 0,
"ifVlan": "",
@@ -1672,7 +1672,7 @@
"ifMtu": 1500,
"ifType": "ethernetCsmacd",
"ifAlias": "air0.101",
"ifPhysAddress": "7a8a20af3422",
"ifPhysAddress": "7a8a20af5643",
"ifHardType": null,
"ifLastChange": 0,
"ifVlan": "",
@@ -1777,7 +1777,7 @@
"ifMtu": 1500,
"ifType": "ethernetCsmacd",
"ifAlias": "br1",
"ifPhysAddress": "7a8a20af3422",
"ifPhysAddress": "7a8a20af5643",
"ifHardType": null,
"ifLastChange": 0,
"ifVlan": "",

View File

@@ -41,11 +41,11 @@
1.3.6.1.2.1.2.2.1.5.7|66|0
1.3.6.1.2.1.2.2.1.6.1|4|
1.3.6.1.2.1.2.2.1.6.2|4|
1.3.6.1.2.1.2.2.1.6.3|4x|788A20AF3422
1.3.6.1.2.1.2.2.1.6.4|4x|7A8A20AF3422
1.3.6.1.2.1.2.2.1.6.5|4x|788A20AF3422
1.3.6.1.2.1.2.2.1.6.6|4x|7A8A20AF3422
1.3.6.1.2.1.2.2.1.6.7|4x|7A8A20AF3422
1.3.6.1.2.1.2.2.1.6.3|4x|788A20AF5643
1.3.6.1.2.1.2.2.1.6.4|4x|7A8A20AF5643
1.3.6.1.2.1.2.2.1.6.5|4x|788A20AF5643
1.3.6.1.2.1.2.2.1.6.6|4x|7A8A20AF5643
1.3.6.1.2.1.2.2.1.6.7|4x|7A8A20AF5643
1.3.6.1.2.1.2.2.1.7.1|2|1
1.3.6.1.2.1.2.2.1.7.2|2|2
1.3.6.1.2.1.2.2.1.7.3|2|1
@@ -202,3 +202,70 @@
1.3.6.1.4.1.41112.1.3.2.1.11.1|2|-42
1.3.6.1.4.1.41112.1.3.2.1.14.1|2|-42
1.3.6.1.4.1.41112.1.3.2.1.40.1|4|v4.0.3
1.3.6.1.4.1.41112.1.3.3.1.1.1|2|1
1.3.6.1.4.1.41112.1.3.3.1.2.1|70|11863834682
1.3.6.1.4.1.41112.1.3.3.1.3.1|70|19046630721
1.3.6.1.4.1.41112.1.3.3.1.4.1|70|16
1.3.6.1.4.1.41112.1.3.3.1.5.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.6.1|70|1844894475537
1.3.6.1.4.1.41112.1.3.3.1.7.1|70|23669076995688
1.3.6.1.4.1.41112.1.3.3.1.8.1|70|2
1.3.6.1.4.1.41112.1.3.3.1.9.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.10.1|70|55
1.3.6.1.4.1.41112.1.3.3.1.11.1|70|24
1.3.6.1.4.1.41112.1.3.3.1.12.1|70|18006635030
1.3.6.1.4.1.41112.1.3.3.1.13.1|70|256720305
1.3.6.1.4.1.41112.1.3.3.1.14.1|70|783281179
1.3.6.1.4.1.41112.1.3.3.1.15.1|70|11854374797
1.3.6.1.4.1.41112.1.3.3.1.16.1|70|3064204
1.3.6.1.4.1.41112.1.3.3.1.17.1|70|6399773
1.3.6.1.4.1.41112.1.3.3.1.18.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.19.1|70|24011916595732
1.3.6.1.4.1.41112.1.3.3.1.20.1|70|19046636640
1.3.6.1.4.1.41112.1.3.3.1.21.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.22.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.23.1|70|956055441
1.3.6.1.4.1.41112.1.3.3.1.24.1|70|1132083598
1.3.6.1.4.1.41112.1.3.3.1.25.1|70|995775223
1.3.6.1.4.1.41112.1.3.3.1.26.1|70|188913529
1.3.6.1.4.1.41112.1.3.3.1.27.1|70|171892827
1.3.6.1.4.1.41112.1.3.3.1.28.1|70|15601916066
1.3.6.1.4.1.41112.1.3.3.1.29.1|70|6
1.3.6.1.4.1.41112.1.3.3.1.30.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.31.1|70|1
1.3.6.1.4.1.41112.1.3.3.1.32.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.33.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.34.1|70|23908578599173
1.3.6.1.4.1.41112.1.3.3.1.35.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.36.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.37.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.38.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.39.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.40.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.41.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.42.1|70|19034580439
1.3.6.1.4.1.41112.1.3.3.1.43.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.44.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.45.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.46.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.47.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.48.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.49.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.50.1|70|1994156125000
1.3.6.1.4.1.41112.1.3.3.1.51.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.52.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.53.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.54.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.55.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.56.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.57.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.58.1|70|11841905945
1.3.6.1.4.1.41112.1.3.3.1.59.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.60.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.61.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.62.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.63.1|70|0
1.3.6.1.4.1.41112.1.3.3.1.64.1|70|23910462694142
1.3.6.1.4.1.41112.1.3.3.1.65.1|70|19046275481
1.3.6.1.4.1.41112.1.3.3.1.66.1|70|1995629150125
1.3.6.1.4.1.41112.1.3.3.1.67.1|70|11852149986