mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Don't run ipmitool without knowing a type (#6504)

Browse Source
This commit is contained in:
Simon Mott
2017-04-25 21:36:52 +01:00
committed by Neil Lathwood
parent 66b7077a01
commit 6c6499c2fe
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
includes/polling/ipmi.inc.php
View File

@@ -18,9 +18,15 @@ if (is_array($ipmi_rows)) {
$remote = " -H " . $ipmi['host'] . " -U '" . $ipmi['user'] . "' -P '" . $ipmi['password'] . "' -L USER"; $remote = " -H " . $ipmi['host'] . " -U '" . $ipmi['user'] . "' -P '" . $ipmi['password'] . "' -L USER";
} }
// Check to see if we know which IPMI interface to use
// so we dont use wrong arguments for ipmitool
if ($ipmi['type'] != '') {
$results = external_exec($config['ipmitool'] . ' -I ' . $ipmi['type'] . ' -c ' . $remote . ' sdr 2>/dev/null'); $results = external_exec($config['ipmitool'] . ' -I ' . $ipmi['type'] . ' -c ' . $remote . ' sdr 2>/dev/null');
d_echo($results); d_echo($results);
echo " done.\n"; echo " done.\n";
} else {
echo " type not yet discovered.\n";
}
foreach (explode("\n", $results) as $row) { foreach (explode("\n", $results) as $row) {
list($desc, $value, $type, $status) = explode(',', $row); list($desc, $value, $type, $status) = explode(',', $row);