mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: rewrite is_valid_port() (#7360)

Browse Source 
* refactor: speed up is_valid_port()
Convert is_valid_port to Config
Several Config optimizations
Update documentation

* fix getCombined() when os key is not set, but global is.
Add more tests
This commit is contained in:
Tony Murray
2017-09-21 18:02:01 +01:00
committed by Neil Lathwood
parent 777eb1f823
commit 6ea6218f47
6 changed files with 140 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ConfigTest.php
+6
View File
@@ -97,6 +97,12 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
$config['os']['nullos']['num'] = array('two', 'three');
$config['assoc'] = array('a' => 'same', 'b' => 'same');
$config['os']['nullos']['assoc'] = array('b' => 'different', 'c' => 'still same');
$config['os']['nullos']['osset'] = true;
$config['gset'] = true;
$this->assertTrue(Config::getCombined('nullos', 'non-existent', true), 'Did not return default value on non-existent key');
$this->assertTrue(Config::getCombined('nullos', 'osset', false), 'Did not return OS value when global value is not set');
$this->assertTrue(Config::getCombined('nullos', 'gset', false), 'Did not return global value when OS value is not set');
$combined = Config::getCombined('nullos', 'num');
sort($combined);