mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added debug to discovery protocols + stop them running if not configured

Browse Source
This commit is contained in:
laf
2015-08-02 19:23:54 +00:00
parent 3a36fc8974
commit 741742aa85
2 changed files with 78 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
includes/common.php
View File

@@ -580,7 +580,12 @@ function edit_service($service, $descr, $service_ip, $service_param = "", $servi
function d_echo($text, $no_debug_text = null) { function d_echo($text, $no_debug_text = null) {
global $debug; global $debug;
if ($debug) { if ($debug) {
echo "$text"; if (is_array($text)) {
print_r($text);
}
else {
echo "$text";
}
} }
elseif ($no_debug_text) { elseif ($no_debug_text) {
echo "$no_debug_text"; echo "$no_debug_text";

132
includes/discovery/discovery-protocols.inc.php
View File

@@ -9,11 +9,13 @@ $community = $device['community'];
if ($device['os'] == 'ironware' && $config['autodiscovery']['xdp'] === true) { if ($device['os'] == 'ironware' && $config['autodiscovery']['xdp'] === true) {
echo ' Brocade FDP: '; echo ' Brocade FDP: ';
$fdp_array = snmpwalk_cache_twopart_oid($device, 'snFdpCacheEntry', array(), 'FOUNDRY-SN-SWITCH-GROUP-MIB'); $fdp_array = snmpwalk_cache_twopart_oid($device, 'snFdpCacheEntry', array(), 'FOUNDRY-SN-SWITCH-GROUP-MIB');
d_echo($fdp_array);
if ($fdp_array) { if ($fdp_array) {
unset($fdp_links); unset($fdp_links);
foreach (array_keys($fdp_array) as $key) { foreach (array_keys($fdp_array) as $key) {
$interface = dbFetchRow('SELECT * FROM `ports` WHERE `device_id` = ? AND `ifIndex` = ?', array($device['device_id'], $key)); $interface = dbFetchRow('SELECT * FROM `ports` WHERE `device_id` = ? AND `ifIndex` = ?', array($device['device_id'], $key));
$fdp_if_array = $fdp_array[$key]; $fdp_if_array = $fdp_array[$key];
d_echo($fdp_if_array);
foreach (array_keys($fdp_if_array) as $entry_key) { foreach (array_keys($fdp_if_array) as $entry_key) {
$fdp = $fdp_if_array[$entry_key]; $fdp = $fdp_if_array[$entry_key];
$remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($fdp['snFdpCacheDeviceId'], $fdp['snFdpCacheDeviceId'])); $remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($fdp['snFdpCacheDeviceId'], $fdp['snFdpCacheDeviceId']));
@@ -38,83 +40,93 @@ if ($device['os'] == 'ironware' && $config['autodiscovery']['xdp'] === true) {
echo ' CISCO-CDP-MIB: '; echo ' CISCO-CDP-MIB: ';
unset($cdp_array); unset($cdp_array);
$cdp_array = snmpwalk_cache_twopart_oid($device, 'cdpCache', array(), 'CISCO-CDP-MIB'); if ($config['autodiscovery']['xdp'] === true) {
if ($cdp_array && $config['autodiscovery']['xdp'] === true) { $cdp_array = snmpwalk_cache_twopart_oid($device, 'cdpCache', array(), 'CISCO-CDP-MIB');
unset($cdp_links); d_echo($cdp_array);
foreach (array_keys($cdp_array) as $key) { if ($cdp_array) {
$interface = dbFetchRow('SELECT * FROM `ports` WHERE device_id = ? AND `ifIndex` = ?', array($device['device_id'], $key)); unset($cdp_links);
$cdp_if_array = $cdp_array[$key]; foreach (array_keys($cdp_array) as $key) {
foreach (array_keys($cdp_if_array) as $entry_key) { $interface = dbFetchRow('SELECT * FROM `ports` WHERE device_id = ? AND `ifIndex` = ?', array($device['device_id'], $key));
$cdp = $cdp_if_array[$entry_key]; $cdp_if_array = $cdp_array[$key];
if (is_valid_hostname($cdp['cdpCacheDeviceId'])) { d_echo($cdp_if_array);
$remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($cdp['cdpCacheDeviceId'], $cdp['cdpCacheDeviceId'])); foreach (array_keys($cdp_if_array) as $entry_key) {
$cdp = $cdp_if_array[$entry_key];
if (is_valid_hostname($cdp['cdpCacheDeviceId'])) {
$remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($cdp['cdpCacheDeviceId'], $cdp['cdpCacheDeviceId']));
if (!$remote_device_id) { if (!$remote_device_id) {
$remote_device_id = discover_new_device($cdp['cdpCacheDeviceId'], $device, 'CDP', $interface); $remote_device_id = discover_new_device($cdp['cdpCacheDeviceId'], $device, 'CDP', $interface);
} }
if ($remote_device_id) { if ($remote_device_id) {
$if = $cdp['cdpCacheDevicePort']; $if = $cdp['cdpCacheDevicePort'];
$remote_port_id = dbFetchCell('SELECT port_id FROM `ports` WHERE (`ifDescr` = ? OR `ifName` = ?) AND `device_id` = ?', array($if, $if, $remote_device_id)); $remote_port_id = dbFetchCell('SELECT port_id FROM `ports` WHERE (`ifDescr` = ? OR `ifName` = ?) AND `device_id` = ?', array($if, $if, $remote_device_id));
}
else {
$remote_port_id = '0';
}
if ($interface['port_id'] && $cdp['cdpCacheDeviceId'] && $cdp['cdpCacheDevicePort']) {
discover_link($interface['port_id'], 'cdp', $remote_port_id, $cdp['cdpCacheDeviceId'], $cdp['cdpCacheDevicePort'], $cdp['cdpCachePlatform'], $cdp['cdpCacheVersion'], $device['device_id'], $remote_device_id);
}
} }
else { else {
$remote_port_id = '0'; echo 'X';
} }//end if
}//end foreach
if ($interface['port_id'] && $cdp['cdpCacheDeviceId'] && $cdp['cdpCacheDevicePort']) {
discover_link($interface['port_id'], 'cdp', $remote_port_id, $cdp['cdpCacheDeviceId'], $cdp['cdpCacheDevicePort'], $cdp['cdpCachePlatform'], $cdp['cdpCacheVersion'], $device['device_id'], $remote_device_id);
}
}
else {
echo 'X';
}//end if
}//end foreach }//end foreach
}//end foreach }//end if
}//end if }//end if
echo ' LLDP-MIB: '; echo ' LLDP-MIB: ';
unset($lldp_array); unset($lldp_array);
$lldp_array = snmpwalk_cache_threepart_oid($device, 'lldpRemoteSystemsData', array(), 'LLDP-MIB');
$dot1d_array = snmpwalk_cache_oid($device, 'dot1dBasePortIfIndex', array(), 'BRIDGE-MIB');
if ($lldp_array && $config['autodiscovery']['xdp'] === true) { if ($config['autodiscovery']['xdp'] === true) {
$lldp_links = ''; $lldp_array = snmpwalk_cache_threepart_oid($device, 'lldpRemoteSystemsData', array(), 'LLDP-MIB');
foreach (array_keys($lldp_array) as $key) { d_echo($lldp_array);
$lldp_if_array = $lldp_array[$key]; $dot1d_array = snmpwalk_cache_oid($device, 'dot1dBasePortIfIndex', array(), 'BRIDGE-MIB');
foreach (array_keys($lldp_if_array) as $entry_key) { d_echo($dot1d_array);
if (is_numeric($dot1d_array[$entry_key]['dot1dBasePortIfIndex'])) { if ($lldp_array) {
$ifIndex = $dot1d_array[$entry_key]['dot1dBasePortIfIndex']; $lldp_links = '';
} foreach (array_keys($lldp_array) as $key) {
else { $lldp_if_array = $lldp_array[$key];
$ifIndex = $entry_key; d_echo($lldp_if_array);
} foreach (array_keys($lldp_if_array) as $entry_key) {
if (is_numeric($dot1d_array[$entry_key]['dot1dBasePortIfIndex'])) {
$interface = dbFetchRow('SELECT * FROM `ports` WHERE `device_id` = ? AND `ifIndex` = ?', array($device['device_id'], $ifIndex)); $ifIndex = $dot1d_array[$entry_key]['dot1dBasePortIfIndex'];
$lldp_instance = $lldp_if_array[$entry_key];
foreach (array_keys($lldp_instance) as $entry_instance) {
$lldp = $lldp_instance[$entry_instance];
$remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($lldp['lldpRemSysName'], $lldp['lldpRemSysName']));
if (!$remote_device_id && is_valid_hostname($lldp['lldpRemSysName'])) {
$remote_device_id = discover_new_device($lldp['lldpRemSysName'], $device, 'LLDP', $interface);
}
if ($remote_device_id) {
$if = $lldp['lldpRemPortDesc'];
$id = $lldp['lldpRemPortId'];
$remote_port_id = dbFetchCell('SELECT `port_id` FROM `ports` WHERE (`ifDescr` = ? OR `ifName` = ? OR `ifDescr` = ? OR `ifName` = ?) AND `device_id` = ?', array($if, $if, $id, $id, $remote_device_id));
} }
else { else {
$remote_port_id = '0'; $ifIndex = $entry_key;
} }
if (is_numeric($interface['port_id']) && isset($lldp['lldpRemSysName']) && isset($lldp['lldpRemPortId'])) { $interface = dbFetchRow('SELECT * FROM `ports` WHERE `device_id` = ? AND `ifIndex` = ?', array($device['device_id'], $ifIndex));
discover_link($interface['port_id'], 'lldp', $remote_port_id, $lldp['lldpRemSysName'], $lldp['lldpRemPortId'], null, $lldp['lldpRemSysDesc'], $device['device_id'], $remote_device_id); $lldp_instance = $lldp_if_array[$entry_key];
} d_echo($lldp_instance);
foreach (array_keys($lldp_instance) as $entry_instance) {
$lldp = $lldp_instance[$entry_instance];
$remote_device_id = dbFetchCell('SELECT `device_id` FROM `devices` WHERE `sysName` = ? OR `hostname` = ?', array($lldp['lldpRemSysName'], $lldp['lldpRemSysName']));
if (!$remote_device_id && is_valid_hostname($lldp['lldpRemSysName'])) {
$remote_device_id = discover_new_device($lldp['lldpRemSysName'], $device, 'LLDP', $interface);
}
if ($remote_device_id) {
$if = $lldp['lldpRemPortDesc'];
$id = $lldp['lldpRemPortId'];
$remote_port_id = dbFetchCell('SELECT `port_id` FROM `ports` WHERE (`ifDescr` = ? OR `ifName` = ? OR `ifDescr` = ? OR `ifName` = ?) AND `device_id` = ?', array($if, $if, $id, $id, $remote_device_id));
}
else {
$remote_port_id = '0';
}
if (is_numeric($interface['port_id']) && isset($lldp['lldpRemSysName']) && isset($lldp['lldpRemPortId'])) {
discover_link($interface['port_id'], 'lldp', $remote_port_id, $lldp['lldpRemSysName'], $lldp['lldpRemPortId'], null, $lldp['lldpRemSysDesc'], $device['device_id'], $remote_device_id);
}
}//end foreach
}//end foreach }//end foreach
}//end foreach }//end foreach
}//end foreach }//end if
}//end if }//end if
echo 'OSPF Discovery: '; echo 'OSPF Discovery: ';