mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

added a fix to round limit values to avoid limits being updated on every discovery since a change of 1rpm in current rpm would cause a new limit since limits are based on the current value

Browse Source
This commit is contained in:
Rasmus Aberg
2015-07-21 13:39:53 +02:00
parent 2ec76a01b1
commit 75e9a0fb27
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
includes/discovery/fanspeeds/extreme.inc.php
View File

@@ -1,6 +1,17 @@
<?php <?php
if ($device['os'] == 'xos') { if ($device['os'] == 'xos') {
// Function used to round limit values to hundreds to avoid h/w/l limits being changed on every discovery as a change of 1rpm for fan speed would cause the limit values to change since they're dynamically calculated
function roundme($val = 0) {
$diff = $val % 100;
if ($diff >= 50) {
$ret = $val + (100-$diff);
} else {
$ret = $val - $diff;
}
return $ret;
}
echo(" EXTREME-BASE-MIB "); echo(" EXTREME-BASE-MIB ");
// Fan Speed // Fan Speed
@@ -16,10 +27,10 @@ if ($device['os'] == 'xos') {
$oid = "1.3.6.1.4.1.1916.1.1.1.9.1.4.$index"; $oid = "1.3.6.1.4.1.1916.1.1.1.9.1.4.$index";
$value = snmp_get($device, $oid, '-Oqv', 'EXTREME-BASE-MIB'); $value = snmp_get($device, $oid, '-Oqv', 'EXTREME-BASE-MIB');
$descr = "Fan Speed $modindex"; $descr = "Fan Speed $modindex";
$high_limit = ($value * 1.5); $high_limit = roundme($value * 1.5);
$high_warn_limit = ($value * 1.25); $high_warn_limit = roundme($value * 1.25);
$low_warn_limit = ($value * 0.75); $low_warn_limit = roundme($value * 0.75);
$low_limit = ($value * 0.5); $low_limit = roundme($value * 0.5);
if (is_numeric($value)) { if (is_numeric($value)) {
discover_sensor($valid['sensor'], 'fanspeed', $device, $oid, $index, 'extreme-fanspeed', $descr, '1', '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value); discover_sensor($valid['sensor'], 'fanspeed', $device, $oid, $index, 'extreme-fanspeed', $descr, '1', '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value);
} }