Automatic fixes for validation failures (#13930)

* Automatic fixes for validations

* webui

* lint fixes

* Fix an install issue with ConfigSeeder requesting cli input in web page.

* Do not use c_echo in validate.php print_fail()

LibreNMS/Interfaces/Validation.php

@@ -0,0 +1,43 @@
+<?php
+/*
+ * Validation.php
+ *
+ * -Description-
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2022 Tony Murray
+ * @author     Tony Murray <murraytony@gmail.com>
+ */
+
+namespace LibreNMS\Interfaces;
+
+use LibreNMS\ValidationResult;
+
+interface Validation
+{
+    /**
+     * Validate this module.
+     */
+    public function validate(): ValidationResult;
+
+    /**
+     * If this validation is enabled or not.
+     *
+     * @return bool
+     */
+    public function enabled(): bool;
+}

LibreNMS/Interfaces/ValidationFixer.php

@@ -0,0 +1,36 @@
+<?php
+/*
+ * ValidationFixer.php
+ *
+ * -Description-
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2022 Tony Murray
+ * @author     Tony Murray <murraytony@gmail.com>
+ */
+
+namespace LibreNMS\Interfaces;
+
+interface ValidationFixer
+{
+    /**
+     * Fix the failed validation result. Take care not to break user installs.
+     *
+     * @return bool
+     */
+    public function fix(): bool;
+}

LibreNMS/Interfaces/ValidationGroup.php

@@ -32,29 +32,21 @@ interface ValidationGroup
     /**
      * Validate this module.
      * To return ValidationResults, call ok, warn, fail, or result methods on the $validator
-     *
-     * @param  Validator  $validator
      */
-    public function validate(Validator $validator);
+    public function validate(Validator $validator): void;
 
     /**
      * Returns if this test should be run by default or not.
-     *
-     * @return bool
      */
-    public function isDefault();
+    public function isDefault(): bool;
 
     /**
      * Returns true if this group has been run
-     *
-     * @return bool
      */
-    public function isCompleted();
+    public function isCompleted(): bool;
 
     /**
      * Mark this group as completed
-     *
-     * @return void
      */
-    public function markCompleted();
+    public function markCompleted(): void;
 }