mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Memcached application improve error visibility (#14536)

Browse Source
This commit is contained in:
Tony Murray
2022-10-31 08:13:41 -05:00
committed by GitHub
parent 55d81fde1e
commit 7d9f22705f
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
includes/polling/applications/memcached.inc.php
View File

@ -12,8 +12,9 @@ if (! empty($agent_data['app']['memcached'])) {
$data = json_app_get($device, $name, '1.1')['data'] ?? [];
$data = $data[$app->app_instance] ?? reset($data);
} catch (JsonAppException $e) {
echo PHP_EOL . $name . ':' . $e->getCode() . ':' . $e->getMessage() . PHP_EOL;
update_application($app, $e->getCode() . ':' . $e->getMessage(), []); // Set empty metrics and error message
$error_string = 'ERROR: ' . $e->getCode() . ':' . $e->getMessage();
echo PHP_EOL . $name . ':' . $error_string . PHP_EOL;
update_application($app, $error_string); // Set empty metrics and error message
return;
}
@ -66,4 +67,4 @@ $fields = [
$app_id = $app->app_id;
$tags = compact('name', 'app_id', 'rrd_name', 'rrd_def');
data_update($device, 'app', $tags, $fields);
update_application($app, $result, $fields);
update_application($app, empty($data) ? 'ERROR: No Data' : 'OK', $fields);