From 7e14405439b71e8b12963be38bfdb1fa32ca96c4 Mon Sep 17 00:00:00 2001
From: Adam Amstrong <adama@localhost>
Date: Thu, 3 May 2012 09:10:58 +0000
Subject: [PATCH] #44 don't discover temperature sensors without numeric
 values. (from Mike Stupalov)

git-svn-id: http://www.observium.org/svn/observer/trunk@3123 61d68cd4-352d-0410-923a-c4978735b2b8
---
 includes/discovery/temperatures/cisco-envmon.inc.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/includes/discovery/temperatures/cisco-envmon.inc.php b/includes/discovery/temperatures/cisco-envmon.inc.php
index 998e9916f1..a9e07fcc30 100644
--- a/includes/discovery/temperatures/cisco-envmon.inc.php
+++ b/includes/discovery/temperatures/cisco-envmon.inc.php
@@ -1,5 +1,7 @@
 <?php
 
+## FIXME - dbFacile and fewer SNMP_GETs
+
 if (mysql_result(mysql_query("SELECT COUNT(*) FROM `sensors` WHERE `device_id` = '".$device['device_id']."' AND `sensor_class` = 'temperature' AND (`sensor_type` = 'cisco-entity-sensor' OR `sensor_type` = 'entity-sensor')"),0) == "0" && ($device['os_group'] == "cisco"))
 {
   echo("CISCO-ENVMON-MIB: ");
@@ -16,7 +18,7 @@ if (mysql_result(mysql_query("SELECT COUNT(*) FROM `sensors` WHERE `device_id` =
       $descr_oid = ".1.3.6.1.4.1.9.9.13.1.3.1.2.$index";
       $descr = snmp_get($device, $descr_oid, "-Oqv", "CISCO-ENVMON-MIB");
       $temperature = snmp_get($device, $oid, "-Oqv", "CISCO-ENVMON-MIB");
-      if (!strstr($descr, "No") && !strstr($temperature, "No") && $descr != "")
+      if (!strstr($descr, "No") && !strstr($temperature, "No") && $temperature != "" && $descr != "")
       {
         $descr = str_replace("\"", "", $descr);
         $descr = str_replace("temperature", "", $descr);