Polling cleanup, fix PHP warnings (#13460)

* Fix warnings up to Arbos

* fixes a-c

* a-r

* a-vrp

* There and back again

* Update test data, couple fixes

* PHPSStan fixes

* style fixes, and fix Asyncos, whoops

* flip serial back.......

* less bogus data

* Poweralert sysName during polling too

* make sure things are calculated in the correct order

* fix style and bad nullables

* update test data

* A comple more conversions

* cambium ptp, misc, and hardware_mib

* remaining except vmware-esxi

* Fixes

* Update baseline

* fixes and fix up baseline

* adjust SnmpQueryMock to upstream options change

* data corrections

* restore slashes

* correctly handle all options input in SnmpQueryMock

* undo ftos changes

* restore vccodec sysDescr
This commit is contained in:
Tony Murray
2021-11-14 14:58:13 -06:00
committed by GitHub
parent bef021b158
commit 7e98e03338
374 changed files with 2313 additions and 3638 deletions

View File

@@ -30,7 +30,7 @@ use LibreNMS\RRD\RrdDefinition;
class Nios extends \LibreNMS\OS implements OSPolling
{
public function pollOS()
public function pollOS(): void
{
//#############
// Create ddns update rrd
@@ -52,10 +52,10 @@ class Nios extends \LibreNMS\OS implements OSPolling
->addDataset('prereq_reject', 'DERIVE', 0);
$fields = [
'success' => $data[0]['ibDDNSUpdateSuccess'],
'failure' => $data[0]['ibDDNSUpdateFailure'],
'reject' => $data[0]['ibDDNSUpdateReject'],
'prereq_reject' => $data[0]['ibDDNSUpdatePrerequisiteReject'],
'success' => $data[0]['ibDDNSUpdateSuccess'] ?? null,
'failure' => $data[0]['ibDDNSUpdateFailure'] ?? null,
'reject' => $data[0]['ibDDNSUpdateReject'] ?? null,
'prereq_reject' => $data[0]['ibDDNSUpdatePrerequisiteReject'] ?? null,
];
$tags = compact('rrd_def');
@@ -78,8 +78,8 @@ class Nios extends \LibreNMS\OS implements OSPolling
->addDataset('PerfnonAA', 'GAUGE', 0);
$fields = [
'PerfAA' => $data[0]['ibNetworkMonitorDNSAAT1AvgLatency'],
'PerfnonAA' => $data[0]['ibNetworkMonitorDNSNonAAT1AvgLatency'],
'PerfAA' => $data[0]['ibNetworkMonitorDNSAAT1AvgLatency'] ?? null,
'PerfnonAA' => $data[0]['ibNetworkMonitorDNSNonAAT1AvgLatency'] ?? null,
];
$tags = compact('rrd_def');
@@ -106,10 +106,10 @@ class Nios extends \LibreNMS\OS implements OSPolling
->addDataset('nxrrset', 'DERIVE', 0);
$fields = [
'success' => $data['"summary"']['ibBindZoneSuccess'],
'failure' => $data['"summary"']['ibBindZoneFailure'],
'nxdomain' => $data['"summary"']['ibBindZoneNxDomain'],
'nxrrset' => $data['"summary"']['ibBindZoneNxRRset'],
'success' => $data['"summary"']['ibBindZoneSuccess'] ?? null,
'failure' => $data['"summary"']['ibBindZoneFailure'] ?? null,
'nxdomain' => $data['"summary"']['ibBindZoneNxDomain'] ?? null,
'nxrrset' => $data['"summary"']['ibBindZoneNxRRset'] ?? null,
];
$tags = compact('rrd_def');
@@ -146,15 +146,15 @@ class Nios extends \LibreNMS\OS implements OSPolling
->addDataset('request', 'DERIVE', 0);
$fields = [
'ack' => $data[0]['ibDhcpTotalNoOfAcks'],
'decline' => $data[0]['ibDhcpTotalNoOfDeclines'],
'discover' => $data[0]['ibDhcpTotalNoOfDiscovers'],
'inform' => $data[0]['ibDhcpTotalNoOfInforms'],
'nack' => $data[0]['ibDhcpTotalNoOfNacks'],
'offer' => $data[0]['ibDhcpTotalNoOfOffers'],
'other' => $data[0]['ibDhcpTotalNoOfOthers'],
'release' => $data[0]['ibDhcpTotalNoOfReleases'],
'request' => $data[0]['ibDhcpTotalNoOfRequests'],
'ack' => $data[0]['ibDhcpTotalNoOfAcks'] ?? null,
'decline' => $data[0]['ibDhcpTotalNoOfDeclines'] ?? null,
'discover' => $data[0]['ibDhcpTotalNoOfDiscovers'] ?? null,
'inform' => $data[0]['ibDhcpTotalNoOfInforms'] ?? null,
'nack' => $data[0]['ibDhcpTotalNoOfNacks'] ?? null,
'offer' => $data[0]['ibDhcpTotalNoOfOffers'] ?? null,
'other' => $data[0]['ibDhcpTotalNoOfOthers'] ?? null,
'release' => $data[0]['ibDhcpTotalNoOfReleases'] ?? null,
'request' => $data[0]['ibDhcpTotalNoOfRequests'] ?? null,
];
$tags = compact('rrd_def');