mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Distributed Poller improved validation (#12269)

Browse Source
This commit is contained in:
Tony Murray
2020-11-23 00:33:56 -06:00
committed by GitHub
parent 7550ef1d8c
commit 7ed34c889e
6 changed files with 164 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
LibreNMS/Validations/DistributedPoller.php
View File

@@ -31,12 +31,18 @@
namespace LibreNMS\Validations;
use App\Models\PollerCluster;
use Carbon\Carbon;
use LibreNMS\Config;
use LibreNMS\Validator;
class DistributedPoller extends BaseValidation
{
protected static $RUN_BY_DEFAULT = false;
public function isDefault()
{
// run by default if distributed polling is enabled
return Config::get('distributed_poller');
}
/**
* Validate this module.
@@ -47,11 +53,62 @@ class DistributedPoller extends BaseValidation
public function validate(Validator $validator)
{
if (! Config::get('distributed_poller')) {
$validator->fail('You have not enabled distributed_poller');
$validator->fail('You have not enabled distributed_poller', 'lnms config:set distributed_poller true');
return;
}
if (! Config::get('rrdcached')) {
$validator->fail('You have not configured $config[\'rrdcached\']');
} elseif (! is_dir(Config::get('rrd_dir'))) {
$validator->fail('You have not configured $config[\'rrd_dir\']');
} else {
Rrd::checkRrdcached($validator);
}
if (PollerCluster::exists()) {
if (PollerCluster::isActive()->exists()) {
$validator->info('Detected Dispatcher Service');
$this->checkDispatcherService($validator);
return;
}
$validator->warn('Dispatcher Service has been used in your cluster, but not recently. It may take up to 5 minutes to register.');
}
$validator->info('Detected Python Wrapper');
$this->checkPythonWrapper($validator);
}
private function checkDispatcherService(Validator $validator)
{
$driver = config('cache.default');
if ($driver != 'redis') {
$validator->warn("Using $driver for distributed locking, you should set CACHE_DRIVER=redis");
}
try {
$lock = \Cache::lock('dist_test_validation');
$lock->get();
$lock->release();
} catch (\Exception $e) {
$validator->fail('Locking server issue: ' . $e->getMessage());
}
$node = PollerCluster::firstWhere('node_id', config('librenms.node_id'));
if (! $node->exists) {
$validator->fail('Dispatcher service is enabled on your cluster, but not in use on this node');
return;
}
if ($node->last_report->lessThan(Carbon::now()->subSeconds($node->getSettingValue('poller_frequency')))) {
$validator->fail('Dispatcher service has not reported stats within the last poller window');
}
}
private function checkPythonWrapper(Validator $validator)
{
if (! Config::get('distributed_poller_memcached_host')) {
$validator->fail('You have not configured $config[\'distributed_poller_memcached_host\']');
} elseif (! Config::get('distributed_poller_memcached_port')) {
@@ -65,13 +122,5 @@ class DistributedPoller extends BaseValidation
$validator->ok('Connection to memcached is ok');
}
}
if (! Config::get('rrdcached')) {
$validator->fail('You have not configured $config[\'rrdcached\']');
} elseif (! is_dir(Config::get('rrd_dir'))) {
$validator->fail('You have not configured $config[\'rrd_dir\']');
} else {
Rrd::checkRrdcached($validator);
}
}
}