Infer character encoding for ifAlias and sysLocation (#13248)

* Infer character encoding for ifAlias and sysLocation Tries to convert character encoding for non-UTF-8 encoded strings. This will only work for snmp strings that are type-hinted, not ones forced to ASCII with -Oa or similar Only works for your default charset or Windows-1251 or LATIN1. You can set your character encoding in .env with CHARSET Please save us all and just use UTF-8 * style fixes * less Yoda * ensure return type * fall back to passed string * don't convert strings with any unprintable characters (such as line return) * Update LibreNMS/Util/StringHelpers.php Co-authored-by: Jellyfrog <[email protected]> * Fix CP850 * fix space Co-authored-by: Jellyfrog <[email protected]>
2024-10-07 16:52:45 +00:00 · 2021-09-21 08:47:44 -05:00
parent 11dfbc02b7
commit 8a883140cb
6 changed files with 92 additions and 1 deletions
@@ -0,0 +1,51 @@
+<?php
+/*
+ * StringHelperTest.php
+ *
+ * -Description-
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2021 Tony Murray
+ * @author     Tony Murray <[email protected]>
+ */
+
+namespace LibreNMS\Tests\Unit\Util;
+
+use LibreNMS\Tests\TestCase;
+use LibreNMS\Util\StringHelpers;
+
+class StringHelperTest extends TestCase
+{
+    /**
+     * A basic feature test example.
+     *
+     * @return void
+     */
+    public function testInferEncoding()
+    {
+        $this->assertEquals(null, StringHelpers::inferEncoding(null));
+        $this->assertEquals('', StringHelpers::inferEncoding(''));
+        $this->assertEquals('~null', StringHelpers::inferEncoding('~null'));
+        $this->assertEquals('Øverbyvegen', StringHelpers::inferEncoding('Øverbyvegen'));
+
+        $this->assertEquals('Øverbyvegen', StringHelpers::inferEncoding(base64_decode('w5h2ZXJieXZlZ2Vu')));
+        $this->assertEquals('Øverbyvegen', StringHelpers::inferEncoding(base64_decode('2HZlcmJ5dmVnZW4=')));
+
+        config(['app.charset' => 'Shift_JIS']);
+        $this->assertEquals('コンサート', StringHelpers::inferEncoding(base64_decode('g1KDk4NUgVuDZw==')));
+    }
+}