mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

PSR2 Cleanup: /html edition

Browse Source 
Travis tests for code conformance. Ignore warnings for now.
Fixed all errors, left most warnings.
This commit is contained in:
Tony Murray
2016-08-18 20:28:22 -05:00
parent f0c82498b5
commit 8c639aa5a4
468 changed files with 6605 additions and 7629 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
html/pages/device/edit/snmp.inc.php
View File

@@ -32,15 +32,13 @@ if ($_POST['editing']) {
if ($_POST['timeout']) {
$update['timeout'] = $timeout;
}
else {
} else {
$update['timeout'] = array('NULL');
}
if ($_POST['retries']) {
$update['retries'] = $retries;
}
else {
} else {
$update['retries'] = array('NULL');
}
@@ -55,8 +53,7 @@ if ($_POST['editing']) {
if (is_numeric($max_repeaters) && $max_repeaters != 0) {
set_dev_attrib($device, 'snmp_max_repeaters', $max_repeaters);
$max_repeaters_set = true;
}
else {
} else {
del_dev_attrib($device, 'snmp_max_repeaters');
$max_repeaters_set = true;
}
@@ -64,22 +61,18 @@ if ($_POST['editing']) {
if ($rows_updated > 0) {
$update_message = $rows_updated.' Device record updated.';
$updated = 1;
}
else if ($rows_updated = '-1') {
} elseif ($rows_updated = '-1') {
if ($max_repeaters_set === true) {
$update_message = 'SNMP Max repeaters updated, no other changes made';
}
else {
} else {
$update_message = 'Device record unchanged. No update necessary.';
}
$updated = -1;
}
else {
} else {
$update_message = 'Device record update error.';
$updated = 0;
}
}
else {
} else {
$update_message = 'Could not connect to device with new SNMP details';
$updated = 0;
}
@@ -91,8 +84,7 @@ $descr = $device['purpose'];
if ($updated && $update_message) {
print_message($update_message);
}
else if ($update_message) {
} elseif ($update_message) {
print_error($update_message);
}
@@ -144,11 +136,12 @@ echo " </select>
";
foreach (get_port_assoc_modes() as $pam) {
$pam_id = get_port_assoc_mode_id ($pam);
$pam_id = get_port_assoc_mode_id($pam);
echo " <option value='$pam_id'";
if ($pam_id == $device['port_association_mode'])
if ($pam_id == $device['port_association_mode']) {
echo " selected='selected'";
}
echo ">$pam</option>\n";
}
@@ -276,8 +269,7 @@ function changeForm() {
<?php
if ($snmpver == 'v3' || $device['snmpver'] == 'v3') {
echo "$('#snmpv1_2').toggle();";
}
else {
} else {
echo "$('#snmpv3').toggle();";
}