mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove $_GET from graphs (#14554)

Browse Source 
Fixes issues setting variables in other contexts
This commit is contained in:
Tony Murray
2022-11-02 08:24:42 -05:00
committed by GitHub
parent 624ebf8d55
commit 95a0050074
31 changed files with 52 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
includes/html/graphs/generic_v3_multiline.inc.php
View File

@@ -53,7 +53,7 @@ foreach ($rrd_list as $rrd) {
$rrd_options .= ' DEF:' . $rrd['ds'] . $i . 'max=' . $rrd['filename'] . ':' . $rrd['ds'] . ':MAX ';
}
if ($_GET['previous']) {
if ($graph_params->visible('previous')) {
$rrd_options .= ' DEF:' . $i . 'X=' . $rrd['filename'] . ':' . $rrd['ds'] . ':AVERAGE:start=' . $prev_from . ':end=' . $from;
$rrd_options .= ' SHIFT:' . $i . "X:$period";
$thingX .= $seperatorX . $i . 'X,UN,0,' . $i . 'X,IF';
@@ -103,7 +103,7 @@ foreach ($rrd_list as $rrd) {
$rrd_options .= " COMMENT:'\\n'";
}//end foreach
if ($_GET['previous'] == 'yes') {
if ($graph_params->visible('previous')) {
if (is_numeric($multiplier)) {
$rrd_options .= ' CDEF:X=' . $thingX . $plusesX . ',' . $multiplier . ',*';
} elseif (is_numeric($divider)) {