mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add type hinting to devicecache (#11975)

Browse Source 
Prevents sql query from executing as string
This commit is contained in:
Jellyfrog
2020-07-31 14:52:18 +02:00
committed by GitHub
parent cb0686d0f3
commit 973a39a0ac
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
LibreNMS/Cache/Device.php
View File

@@ -46,7 +46,7 @@ class Device
*
* @param int $device_id
*/
public function setPrimary($device_id)
public function setPrimary(int $device_id)
{
$this->primary = $device_id;
}
@@ -57,13 +57,13 @@ class Device
* @param int $device_id
* @return \App\Models\Device
*/
public function get($device_id) : \App\Models\Device
public function get(?int $device_id) : \App\Models\Device
{
if (!array_key_exists($device_id, $this->devices)) {
if (!is_null($device_id) && !array_key_exists($device_id, $this->devices)) {
return $this->load($device_id);
}
return $this->devices[$device_id] ?: new \App\Models\Device;
return $this->devices[$device_id] ?? new \App\Models\Device;
}
/**
@@ -80,7 +80,7 @@ class Device
return $this->load($hostname, 'hostname');
}
return $this->devices[$device_id] ?: new \App\Models\Device;
return $this->devices[$device_id] ?? new \App\Models\Device;
}
/**
@@ -89,7 +89,7 @@ class Device
* @param int $device_id
* @return \App\Models\Device
*/
public function refresh($device_id) : \App\Models\Device
public function refresh(?int $device_id) : \App\Models\Device
{
unset($this->devices[$device_id]);
return $this->get($device_id);