diff --git a/includes/html/pages/device/routing/bgp.inc.php b/includes/html/pages/device/routing/bgp.inc.php index be900916c2..8b99721b1d 100644 --- a/includes/html/pages/device/routing/bgp.inc.php +++ b/includes/html/pages/device/routing/bgp.inc.php @@ -110,28 +110,17 @@ if ($vars['view'] == 'macaccounting_pkts') { print_optionbar_end(); -echo ''; +echo '
'; echo ''; $i = '1'; foreach (dbFetchRows("SELECT * FROM `bgpPeers` WHERE `device_id` = ? $extra_sql ORDER BY `bgpPeerRemoteAs`, `bgpPeerIdentifier`", [$device['device_id']]) as $peer) { $has_macaccounting = dbFetchCell('SELECT COUNT(*) FROM `ipv4_mac` AS I, mac_accounting AS M WHERE I.ipv4_address = ? AND M.mac = I.mac_address', [$peer['bgpPeerIdentifier']]); - if (! is_integer($i / 2)) { - $bg_colour = \LibreNMS\Config::get('list_colour.even'); - } else { - $bg_colour = \LibreNMS\Config::get('list_colour.odd'); - } unset($alert); unset($peerhost, $peername); - if (! is_integer($i / 2)) { - $bg_colour = \LibreNMS\Config::get('list_colour.odd'); - } else { - $bg_colour = \LibreNMS\Config::get('list_colour.even'); - } - if ($peer['bgpPeerState'] == 'established') { $col = 'green'; } else { @@ -241,7 +230,7 @@ foreach (dbFetchRows("SELECT * FROM `bgpPeers` WHERE `device_id` = ? $extra_sql $last_error = describe_bgp_error_code($peer['bgpPeerLastErrorCode'], $peer['bgpPeerLastErrorSubCode']) . '
' . $peer['bgpPeerLastErrorText']; } - echo ' + echo ' '; echo ' @@ -255,8 +244,7 @@ foreach (dbFetchRows("SELECT * FROM `bgpPeers` WHERE `device_id` = ? $extra_sql - - '; + '; unset($invalid); @@ -297,7 +285,7 @@ foreach (dbFetchRows("SELECT * FROM `bgpPeers` WHERE `device_id` = ? $extra_sql $graph_array['height'] = '100'; $graph_array['width'] = '216'; $graph_array['to'] = \LibreNMS\Config::get('time.now'); - echo '
Peer addressTypeFamilyRemote ASPeer descriptionStateLast errorUptime
' . \LibreNMS\Util\Time::formatInterval($peer['bgpPeerFsmEstablishedTime']) . "
Updates " . $peer['bgpPeerInUpdates'] . " " . $peer['bgpPeerOutUpdates'] . '
'; + echo '
'; include 'includes/html/print-graphrow.inc.php'; diff --git a/includes/html/pages/device/routing/cef.inc.php b/includes/html/pages/device/routing/cef.inc.php index cedcb93940..8ab6b72d4b 100644 --- a/includes/html/pages/device/routing/cef.inc.php +++ b/includes/html/pages/device/routing/cef.inc.php @@ -37,16 +37,17 @@ if ($vars['view'] == 'graphs') { print_optionbar_end(); -echo '
- '; - -echo ' +echo '
+
+
Entity
+ + - '; + '; $i = 0; @@ -68,7 +69,7 @@ foreach (dbFetchRows('SELECT * FROM `cef_switching` WHERE `device_id` = ? ORDER $entity_descr = $entity['entPhysicalName'] . ' (' . $entity['entPhysicalModelName'] . ')'; } - echo " + echo ''; - echo ' + echo ' '; if ($vars['view'] == 'graphs') { @@ -129,4 +130,4 @@ foreach (dbFetchRows('SELECT * FROM `cef_switching` WHERE `device_id` = ? ORDER $i++; } -echo '
Entity AFI Path Drop Punt Punt2Host
" . $entity_descr . '
' . $entity_descr . ' ' . $cef['afi'] . ' '; @@ -109,7 +110,7 @@ foreach (dbFetchRows('SELECT * FROM `cef_switching` WHERE `device_id` = ? ORDER echo '
'; +echo '
'; diff --git a/includes/html/pages/device/routing/vrf.inc.php b/includes/html/pages/device/routing/vrf.inc.php index 14ab8fa1e7..5d37ea69d2 100644 --- a/includes/html/pages/device/routing/vrf.inc.php +++ b/includes/html/pages/device/routing/vrf.inc.php @@ -66,7 +66,21 @@ foreach ($graph_types as $type => $descr) { print_optionbar_end(); -echo "
"; +echo ' +
+
+
+
+ + + + + + + + + '; + $i = '0'; foreach (dbFetchRows('SELECT * FROM `vrfs` WHERE `device_id` = ? ORDER BY `vrf_name`', [$device['device_id']]) as $vrf) { include 'includes/html/print-vrf.inc.php'; diff --git a/includes/html/pages/routing/vrf.inc.php b/includes/html/pages/routing/vrf.inc.php index 3f6f7ee277..1901d3c25c 100644 --- a/includes/html/pages/routing/vrf.inc.php +++ b/includes/html/pages/routing/vrf.inc.php @@ -64,6 +64,20 @@ if (! Auth::user()->hasGlobalRead()) { print_optionbar_end(); + echo ' +
+
+
+
 VRFDescriptionRDInterfaces
+ + + + + + + + '; + if ($vars['view'] == 'basic' || $vars['view'] == 'graphs') { // Pre-Cache in arrays // That's heavier on RAM, but much faster on CPU (1:40) @@ -89,16 +103,10 @@ if (! Auth::user()->hasGlobalRead()) { } } - echo "
 VRFRDInterfaces
"; $i = '1'; + echo ''; foreach (dbFetchRows('SELECT `vrf_name`, `mplsVpnVrfRouteDistinguisher`, `mplsVpnVrfDescription` FROM `vrfs` GROUP BY `mplsVpnVrfRouteDistinguisher`, `mplsVpnVrfDescription`,`vrf_name`') as $vrf) { - if ($i % 2) { - $bg_colour = Config::get('list_colour.even'); - } else { - $bg_colour = Config::get('list_colour.odd'); - } - - echo ""; + echo ''; echo ''; + echo ''; $x++; } //end foreach - echo '
'; echo ' 'detail', 'vrf' => $vrf['vrf_name']]) . '>'; echo $vrf['vrf_name'] . '
'; @@ -121,7 +129,7 @@ if (! Auth::user()->hasGlobalRead()) { } } - echo "
'device'], ['device' => $device['device_id'], 'tab' => 'routing', 'view' => 'basic', 'proto' => 'vrf']); echo "'>" . DeviceCache::get($device['device_id'])->displayName() . ' '; @@ -162,11 +170,11 @@ if (! Auth::user()->hasGlobalRead()) { }//end switch }//end foreach - echo '
'; + echo ''; $i++; }//end foreach echo '
'; diff --git a/includes/html/print-vrf.inc.php b/includes/html/print-vrf.inc.php index 71f7818f2a..a5513726a1 100644 --- a/includes/html/print-vrf.inc.php +++ b/includes/html/print-vrf.inc.php @@ -1,13 +1,8 @@ "; +echo ''; echo "" . $vrf['vrf_name'] . ''; echo '' . $vrf['mplsVpnVrfDescription'] . ''; @@ -35,4 +30,4 @@ foreach (dbFetchRows('SELECT * FROM ports WHERE `device_id` = ? AND `ifVrf` = ?' } echo ''; -echo ''; +echo '';