From a319f92b3ccd8eae2c9fe9cabf1c226033303539 Mon Sep 17 00:00:00 2001 From: Tom Laermans Date: Wed, 27 Apr 2011 16:05:41 +0000 Subject: [PATCH] fix ipmi sensor rrds git-svn-id: http://www.observium.org/svn/observer/trunk@2184 61d68cd4-352d-0410-923a-c4978735b2b8 --- includes/polling/ipmi.inc.php | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/includes/polling/ipmi.inc.php b/includes/polling/ipmi.inc.php index a4d054e043..4ac3be2dc1 100644 --- a/includes/polling/ipmi.inc.php +++ b/includes/polling/ipmi.inc.php @@ -26,11 +26,20 @@ if ($ipmi['host'] = get_dev_attrib($device,'ipmi_hostname')) $sensor = $ipmi_sensor[$ipmisensors['sensor_descr']][$ipmisensors['sensor_class']]['value']; $unit = $ipmi_sensor[$ipmisensors['sensor_descr']][$ipmisensors['sensor_class']]['unit']; - $sensorrrd = $config['rrd_dir'] . "/" . $device['hostname'] . "/" . safename($ipmisensors['sensor_class'].'-'.$ipmisensors['sensor_type'].'-'.$ipmisensors['sensor_index'] . ".rrd"); + $rrd_file = get_sensor_rrd($device, $ipmisensors); - if (!is_file($sensorrrd)) + ## FIXME - sensor name format change 2011/04/26 - remove this in $amount_of_time. + ## We don't want to reduce performance forever because douchebags don't svn up! + $old_rrd_file = $config['rrd_dir'] . "/" . $device['hostname'] . "/" . safename($ipmisensors['sensor_class'].'-'.$ipmisensors['sensor_type'].'-'.$ipmisensors['sensor_index'] . ".rrd"); + + if (is_file($old_rrd_file)) { - rrdtool_create($sensorrrd,"--step 300 \ + rename($old_rrd_file, $rrd_file); + } + + if (!is_file($rrd_file)) + { + rrdtool_create($rrd_file,"--step 300 \ DS:sensor:GAUGE:600:-20000:20000 \ RRA:AVERAGE:0.5:1:600 \ RRA:AVERAGE:0.5:6:700 \ @@ -48,7 +57,7 @@ if ($ipmi['host'] = get_dev_attrib($device,'ipmi_hostname')) echo($sensor . " $unit\n"); - rrdtool_update($sensorrrd,"N:$sensor"); + rrdtool_update($rrd_file,"N:$sensor"); ## FIXME warnings in event & mail not done here yet!