save-test-data.php: Print a message when we encounter a bad module name (#8274)

* Print a message when we encounter a bad module name (likely a typo)

* Raise exception for invalid module name and handle it.
This commit is contained in:
Tony Murray
2018-02-25 20:03:18 -06:00
committed by GitHub
parent 6dcdd89dd7
commit b2ce9b173b
5 changed files with 75 additions and 28 deletions

View File

@@ -27,6 +27,7 @@ namespace LibreNMS\Util;
use LibreNMS\Config;
use LibreNMS\Exceptions\FileNotFoundException;
use LibreNMS\Exceptions\InvalidModuleException;
use Symfony\Component\Yaml\Yaml;
class ModuleTestHelper
@@ -57,6 +58,7 @@ class ModuleTestHelper
* @param array|string $modules
* @param string $os
* @param string $variant
* @throws InvalidModuleException
*/
public function __construct($modules, $os, $variant = '')
{
@@ -273,6 +275,7 @@ class ModuleTestHelper
*
* @param array $modules
* @return array
* @throws InvalidModuleException
*/
private function resolveModuleDependencies($modules)
{
@@ -281,7 +284,7 @@ class ModuleTestHelper
foreach ($modules as $module) {
// only allow valid modules
if (!(Config::has("poller_modules.$module") || Config::has("discovery_modules.$module"))) {
continue;
throw new InvalidModuleException("Invalid module name: $module");
}
if (isset($this->module_deps[$module])) {