mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #11878 from Jellyfrog/bug/security-fixes

Browse Source 
Prevent unauthorized access to device graphs
This commit is contained in:
Tony Murray
2020-06-30 07:55:35 -05:00
committed by GitHub
parent 4da411c839 659325d5d0
commit b36ab394a8
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/DeviceController.php
View File

@@ -72,6 +72,12 @@ class DeviceController extends Controller
if ($current_tab == 'port') { if ($current_tab == 'port') {
$vars = Url::parseLegacyPath($request->path()); $vars = Url::parseLegacyPath($request->path());
$port = Port::findOrFail($vars->get('port')); $port = Port::findOrFail($vars->get('port'));
// This prevents users from traversal device id's by piggybacking on the auth for the specified port
if ($port->device_id !== $device_id) {
abort(404);
}
$this->authorize('view', $port); $this->authorize('view', $port);
} else { } else {
$this->authorize('view', $device); $this->authorize('view', $device);

4
html/graph.php
View File

@@ -17,9 +17,7 @@ $start = microtime(true);
$init_modules = array('web', 'graphs', 'auth'); $init_modules = array('web', 'graphs', 'auth');
require realpath(__DIR__ . '/..') . '/includes/init.php'; require realpath(__DIR__ . '/..') . '/includes/init.php';
$auth = Auth::check() || is_client_authorized($_SERVER['REMOTE_ADDR']); if (!(Auth::check() || is_client_authorized($_SERVER['REMOTE_ADDR']))) {
if (!$auth) {
die('Unauthorized'); die('Unauthorized');
} }