diff --git a/includes/discovery/os/procurve.inc.php b/includes/discovery/os/procurve.inc.php index 651b4a6b65..1c484495ed 100644 --- a/includes/discovery/os/procurve.inc.php +++ b/includes/discovery/os/procurve.inc.php @@ -1,5 +1,9 @@ = 5 - // sysDescr.0 = STRING: RouterOS RB493AH - if (preg_match('/^RouterOS/', $sysDescr)) { - $os = 'routeros'; - } - - // poll Cisco AAA MIB - if (!empty($os)) { - $extra_mibs = array( - "ciscoAAASessionMIB" => "CISCO-AAA-SESSION-MIB", - ); - register_mibs($device, $extra_mibs, "includes/discovery/os/routeros.inc.php"); - } +if (str_contains($sysDescr, 'router') && is_numeric(snmp_get($device, 'SNMPv2-SMI::enterprises.14988.1.1.4.3.0', '-Oqv', ''))) { + $os = 'routeros'; +} + +if (str_contains($sysDescr, 'RouterOS')) { + $os = 'routeros'; +} + +if (!empty($os)) { + $extra_mibs = array( + "ciscoAAASessionMIB" => "CISCO-AAA-SESSION-MIB", + ); + register_mibs($device, $extra_mibs, "includes/discovery/os/routeros.inc.php"); } diff --git a/includes/discovery/os/ruckuswireless.inc.php b/includes/discovery/os/ruckuswireless.inc.php index dad1284847..5790ccd8f8 100644 --- a/includes/discovery/os/ruckuswireless.inc.php +++ b/includes/discovery/os/ruckuswireless.inc.php @@ -12,16 +12,14 @@ * the source code distribution for details. */ -if (!$os) { - if (strstr($sysObjectId, '.1.3.6.1.4.1.25053.3.1')) { - $os = 'ruckuswireless'; +if (starts_with($sysObjectId, '.1.3.6.1.4.1.25053.3.1')) { + $os = 'ruckuswireless'; - $ruckus_mibs = array( - "ruckusZDSystemStats" => "RUCKUS-ZD-SYSTEM-MIB", - "ruckusZDWLANTable" => "RUCKUS-ZD-WLAN-MIB", - "ruckusZDWLANAPTable" => "RUCKUS-ZD-WLAN-MIB", - "ruckusZDWLANAPRadioStatsTable" => "RUCKUS-ZD-WLAN-MIB", - ); - register_mibs($device, $ruckus_mibs, "includes/discovery/os/ruckuswireless.inc.php"); - } + $ruckus_mibs = array( + "ruckusZDSystemStats" => "RUCKUS-ZD-SYSTEM-MIB", + "ruckusZDWLANTable" => "RUCKUS-ZD-WLAN-MIB", + "ruckusZDWLANAPTable" => "RUCKUS-ZD-WLAN-MIB", + "ruckusZDWLANAPRadioStatsTable" => "RUCKUS-ZD-WLAN-MIB", + ); + register_mibs($device, $ruckus_mibs, "includes/discovery/os/ruckuswireless.inc.php"); }