From bafc195ae32bb00d0584213ca20e1828d1f72c01 Mon Sep 17 00:00:00 2001
From: Yann Gauteron <37099668+amigne@users.noreply.github.com>
Date: Tue, 19 Mar 2019 14:12:54 +0100
Subject: [PATCH] Fix cisco temperature limit (#9985)

* The SNMP value ciscoEnvMonTemperatureThreshold is now stored as high limit (and no more as high warning limit)

* Updating misc/notifications.rss to make the user aware of the behavioral change

* Addition of missing </description> in the misc/notifications.rss
---
 includes/discovery/sensors/temperature/cisco.inc.php | 2 +-
 misc/notifications.rss                               | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/includes/discovery/sensors/temperature/cisco.inc.php b/includes/discovery/sensors/temperature/cisco.inc.php
index 40196a4a1e..0c15959b0d 100644
--- a/includes/discovery/sensors/temperature/cisco.inc.php
+++ b/includes/discovery/sensors/temperature/cisco.inc.php
@@ -16,7 +16,7 @@ if (is_array($temp)) {
     foreach ($temp as $index => $entry) {
         if ($temp[$index]['ciscoEnvMonTemperatureState'] != 'notPresent' && !empty($temp[$index]['ciscoEnvMonTemperatureStatusDescr'])) {
             $descr = ucwords($temp[$index]['ciscoEnvMonTemperatureStatusDescr']);
-            discover_sensor($valid['sensor'], 'temperature', $device, $cur_oid.$index, $index, 'cisco', $descr, '1', '1', null, null, $temp[$index]['ciscoEnvMonTemperatureThreshold'], null, $temp[$index]['ciscoEnvMonTemperatureStatusValue'], 'snmp', $index);
+            discover_sensor($valid['sensor'], 'temperature', $device, $cur_oid . $index, $index, 'cisco', $descr, '1', '1', null, null, null, $temp[$index]['ciscoEnvMonTemperatureThreshold'], $temp[$index]['ciscoEnvMonTemperatureStatusValue'], 'snmp', $index);
         }
     }
 }
diff --git a/misc/notifications.rss b/misc/notifications.rss
index 69311cbb5d..219b89ac24 100644
--- a/misc/notifications.rss
+++ b/misc/notifications.rss
@@ -53,5 +53,10 @@
     <description>As described previously, Legacy Alert Templates and Transports have been removed.  You can find more info here: https://community.librenms.org/t/deprecation-notice-alerting-legacy-transports-and-templates/5915</description>
     <pubDate>Fri, 15 Feb 2017 23:00:00 +0000</pubDate>
   </item>
+    <item>
+      <title>Cisco Temperature Sensor Threshold Values Stored as High Limits</title>
+      <description>During discovery, some temperature sensors discovered on Cisco devices had their highest temperature value stored as warning high limit. For new discovered devices, this value is now stored as high limit.</description>
+      <pubDate>Sun, 17 Mar 2019 21:00:00 +0100</pubDate>
+    </item>
 </channel>
 </rss>