Availability module fixes (#15369)

* Refactor poller to allow modules to run even if the device is down Include core in config (but not webui) to avoid silly shenanigans Inject datastore into polling * Needed to split datastore interface * Cleanup some data_udpate() references * Apply fixes from StyleCI * Fix legacy poller :D * Output to the correct stream * Fix lint issues * Apply fixes from StyleCI * Fix discovery not including core and submodule handling * Use whereRaw --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-10-07 16:52:45 +00:00 · 2023-10-04 10:32:59 -05:00
parent 4211b1c46f
commit c1258320f8
78 changed files with 845 additions and 433 deletions
--- a/LibreNMS/Polling/ModuleStatus.php
+++ b/LibreNMS/Polling/ModuleStatus.php
@@ -0,0 +1,82 @@
+<?php
+/**
+ * ModuleStatus.php
+ *
+ * -Description-
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * @link       https://www.librenms.org
+ *
+ * @copyright  2023 Tony Murray
+ * @author     Tony Murray <murraytony@gmail.com>
+ */
+
+namespace LibreNMS\Polling;
+
+class ModuleStatus
+{
+    public function __construct(
+        public bool $global,
+        public ?bool $os = null,
+        public ?bool $device = null,
+        public ?bool $manual = null,
+    ) {
+    }
+
+    public function isEnabled(): bool
+    {
+        if ($this->manual !== null) {
+            return $this->manual;
+        }
+
+        if ($this->device !== null) {
+            return $this->device;
+        }
+
+        if ($this->os !== null) {
+            return $this->os;
+        }
+
+        return $this->global;
+    }
+
+    public function reason(): string
+    {
+        if ($this->manual !== null) {
+            return 'mannually';
+        }
+
+        if ($this->device !== null) {
+            return 'by device';
+        }
+
+        if ($this->os !== null) {
+            return 'by OS';
+        }
+
+        return 'globally';
+    }
+
+    public function __toString(): string
+    {
+        return sprintf('Module %s: Global %s | OS %s | Device %s | Manual %s',
+            $this->isEnabled() ? 'enabled' : 'disabled',
+            $this->global ? '+' : '-',
+            $this->os === null ? ' ' : ($this->os ? '+' : '-'),
+            $this->device === null ? ' ' : ($this->device ? '+' : '-'),
+            $this->manual === null ? ' ' : ($this->manual ? '+' : '-'),
+        );
+    }
+}