Poller rewrite (Try 2) (#13525)

* core WIP * try to finish up * trim space too and a couple of cleanups * update test data * put escapes back * another net-snmp difference * correct copy paste error * WIP * Use new code YAY * a tiny bit more * Kind of working * Handle manual modules correctly * convert core to modern module * Only save metrics if modules is not overridden * correct module exists check * database error handling * debug handling * restore bad changes * Introduce Actions RunAlertRulesAction UpdateDeviceGroupsAction * tweaks to output * Fix some issues in outside code * Style fixes * fixes to module status checks * typehints! * Use logger only and DI * OS module not named correctly * Work on quiet output a bit more * generically don't change output when disabling debug if the driver is already stack * Fix missing $device variable for legacy os polling Fix missing dbFacile functions when no legacy modules polled in RunAlertRulesAction * restore legacy os module shim * use the new poller code for tests * PollingDevice event * Fix some issues and enable/disable error reporting around legacy modules * typehints * fully update baseline * Use Process for version commands so we don't leak debug output. * don't detect rrdtool version in ci every time * style fixes * Warning fixes * more fixes * re-update baseline * remove diff noise * fix up alerts * Catch exceptions in device ip lookup * Revert accidental snmp.inc.php poller target change (should have been ?: not ??)
2024-10-07 16:52:45 +00:00 · 2021-11-17 19:23:55 -06:00
parent 7893b8bebe
commit c79b187d72
48 changed files with 1187 additions and 305 deletions
--- a/app/Actions/Device/UpdateDeviceGroupsAction.php
+++ b/app/Actions/Device/UpdateDeviceGroupsAction.php
@@ -0,0 +1,85 @@
+<?php
+/**
+ * UpdateDeviceGroupsAction.php
+ *
+ * Update device group associations by re-checking rules
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * @link       http://librenms.org
+ *
+ * @copyright  2021 Tony Murray
+ * @author     Tony Murray <murraytony@gmail.com>
+ */
+
+namespace App\Actions\Device;
+
+use App\Models\Device;
+use App\Models\DeviceGroup;
+use Log;
+
+class UpdateDeviceGroupsAction
+{
+    /**
+     * @var \App\Models\Device
+     */
+    private $device;
+
+    public function __construct(Device $device)
+    {
+        $this->device = $device;
+    }
+
+    /**
+     * @return array[]
+     */
+    public function execute(): array
+    {
+        if (! $this->device->exists) {
+            // Device not saved to DB, cowardly refusing
+            return [
+                'attached' => [],
+                'detached' => [],
+                'updated' => [],
+            ];
+        }
+
+        $device_group_ids = DeviceGroup::query()
+            ->with(['devices' => function ($query) {
+                $query->select('devices.device_id');
+            }])
+            ->get()
+            ->filter(function (DeviceGroup $device_group) {
+                if ($device_group->type == 'dynamic') {
+                    try {
+                        return $device_group->getParser()
+                            ->toQuery()
+                            ->where('devices.device_id', $this->device->device_id)
+                            ->exists();
+                    } catch (\Illuminate\Database\QueryException $e) {
+                        Log::error("Device Group '$device_group->name' generates invalid query: " . $e->getMessage());
+
+                        return false;
+                    }
+                }
+
+                // for static, if this device is include, keep it.
+                return $device_group->devices
+                    ->where('device_id', $this->device->device_id)
+                    ->isNotEmpty();
+            })->pluck('id');
+
+        return $this->device->groups()->sync($device_group_ids);
+    }
+}