Poller rewrite (Try 2) (#13525)

* core WIP

* try to finish up

* trim space too
and a couple of cleanups

* update test data

* put escapes back

* another net-snmp difference

* correct copy paste error

* WIP

* Use new code YAY

* a tiny bit more

* Kind of working

* Handle manual modules correctly

* convert core to modern module

* Only save metrics if modules is not overridden

* correct module exists check

* database error handling

* debug handling

* restore bad changes

* Introduce Actions
 RunAlertRulesAction
 UpdateDeviceGroupsAction

* tweaks to output

* Fix some issues in outside code

* Style fixes

* fixes to module status checks

* typehints!

* Use logger only and DI

* OS module not named correctly

* Work on quiet output a bit more

* generically don't change output when disabling debug if the driver is already stack

* Fix missing $device variable for legacy os polling
Fix missing dbFacile functions when no legacy modules polled in RunAlertRulesAction

* restore legacy os module shim

* use the new poller code for tests

* PollingDevice event

* Fix some issues and enable/disable error reporting around legacy modules

* typehints

* fully update baseline

* Use Process for version commands so we don't leak debug output.

* don't detect rrdtool version in ci every time

* style fixes

* Warning fixes

* more fixes

* re-update baseline

* remove diff noise

* fix up alerts

* Catch exceptions in device ip lookup

* Revert accidental snmp.inc.php poller target change
(should have been ?: not ??)

tests/OSModulesTest.php

@@ -100,10 +100,8 @@ class OSModulesTest extends DBTestCase
             $filename = $helper->getJsonFilepath(true);
             $expected_data = $helper->getTestData();
             $results = $helper->generateTestData($this->getSnmpsim(), true);
-        } catch (FileNotFoundException $e) {
-            return $this->fail($e->getMessage());
-        } catch (InvalidModuleException $e) {
-            return $this->fail($e->getMessage());
+        } catch (FileNotFoundException|InvalidModuleException $e) {
+            $this->fail($e->getMessage());
         }
 
         if (is_null($results)) {
@@ -168,8 +166,10 @@ class OSModulesTest extends DBTestCase
     private function stubClasses(): void
     {
         $this->app->bind('log', function ($app) {
-            return \Mockery::mock('\App\Facades\LogManager[event]', [$app])
-                ->shouldReceive('event');
+            $mock = \Mockery::mock('\App\Facades\LogManager[event]', [$app]);
+            $mock->shouldReceive('event');
+
+            return $mock;
         });
 
         $this->app->bind(Fping::class, function ($app) {