mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug - ADSL ifIndex to port error not handled (#15617)

Browse Source 
* fix

* add an error message
This commit is contained in:
PipoCanaja
2023-12-05 14:11:46 +01:00
committed by GitHub
parent fe144d605a
commit c88fba0b64
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
LibreNMS/Modules/Xdsl.php
View File

@@ -150,6 +150,12 @@ class Xdsl implements Module
$portAdsl->port_id = $os->ifIndexToId($ifIndex); $portAdsl->port_id = $os->ifIndexToId($ifIndex);
if ($portAdsl->port_id == 0) {
// failure of ifIndexToId(), port_id is invalid, and syncModels will crash
echo ' ADSL( Failed to discover this port, ifIndex invalid : ' . $portAdsl->adslLineCoding . '/' . Number::formatSi($portAdsl->adslAtucChanCurrTxRate, 2, 3, 'bps') . '/' . Number::formatSi($portAdsl->adslAturChanCurrTxRate, 2, 3, 'bps') . ') ';
continue;
}
if ($datastore) { if ($datastore) {
$this->storeAdsl($portAdsl, $data, (int) $ifIndex, $os, $datastore); $this->storeAdsl($portAdsl, $data, (int) $ifIndex, $os, $datastore);
echo ' ADSL(' . $portAdsl->adslLineCoding . '/' . Number::formatSi($portAdsl->adslAtucChanCurrTxRate, 2, 3, 'bps') . '/' . Number::formatSi($portAdsl->adslAturChanCurrTxRate, 2, 3, 'bps') . ') '; echo ' ADSL(' . $portAdsl->adslLineCoding . '/' . Number::formatSi($portAdsl->adslAtucChanCurrTxRate, 2, 3, 'bps') . '/' . Number::formatSi($portAdsl->adslAturChanCurrTxRate, 2, 3, 'bps') . ') ';