Run flake8 on poller-wrapper; use sensible date format

poller-wrapper.py

@@ -26,7 +26,15 @@
                 published from: The Netherlands.
 """
 try:
-    import threading, Queue, sys, subprocess, time, os, json
+
+    import json
+    import os
+    import Queue
+    import subprocess
+    import sys
+    import threading
+    import time
+
 except:
     print "ERROR: missing one or more of the following python modules:"
     print "threading, Queue, sys, subprocess, time, os, json"
@@ -47,6 +55,7 @@ except:
 ob_install_dir = os.path.dirname(os.path.realpath(__file__))
 config_file = ob_install_dir + '/config.php'
 
+
 def get_config_data():
     config_cmd = ['/usr/bin/env', 'php', '%s/config_to_json.php' % ob_install_dir]
     try:
@@ -57,7 +66,8 @@ def get_config_data():
     return proc.communicate()[0]
 
 try:
-    with open(config_file) as f: pass
+    with open(config_file) as f:
+        pass
 except IOError as e:
     print "ERROR: Oh dear... %s does not seem readable" % config_file
     sys.exit(2)
@@ -80,6 +90,7 @@ if 'distributed_poller_group' in config:
 else:
     poller_group = False
 
+
 def memc_alive():
     try:
         global memc
@@ -93,6 +104,7 @@ def memc_alive():
     except:
         return False
 
+
 def memc_touch(key, time):
     try:
         global memc
@@ -101,12 +113,17 @@ def memc_touch(key,time):
     except:
         pass
 
-if 'distributed_poller' in config and 'distributed_poller_memcached_host' in config and 'distributed_poller_memcached_port' in config and config['distributed_poller'] == True:
+if ('distributed_poller' in config and
+    'distributed_poller_memcached_host' in config and
+    'distributed_poller_memcached_port' in config and
+        config['distributed_poller']):
     try:
-        import memcache, uuid
+        import memcache
-        memc = memcache.Client([config['distributed_poller_memcached_host']+':'+str(config['distributed_poller_memcached_port'])])
+        import uuid
-        if memc_alive() == True:
+        memc = memcache.Client([config['distributed_poller_memcached_host'] + ':' +
-            if memc.get("poller.master") == None:
+            str(config['distributed_poller_memcached_port'])])
+        if memc_alive():
+            if memc.get("poller.master") is None:
                 print "Registered as Master"
                 memc.set("poller.master", config['distributed_poller_name'], 10)
                 memc.set("poller.nodes", 0, 300)
@@ -174,7 +191,7 @@ devices = cursor.fetchall()
 for row in devices:
     devices_list.append(int(row[0]))
 # (c) 2015, GPLv3, Daniel Preussker <f0o@devilcode.org> <<<EOC3
-if distpoll is True and IsNode is False:
+if distpoll and not IsNode:
     query = "select max(device_id),min(device_id) from devices"
     cursor.execute(query)
     devices = cursor.fetchall()
@@ -190,17 +207,18 @@ if distpoll is True and IsNode is False:
         "I know, I'll use threads," and then two they hav erpoblesms.
 """
 
+
 def printworker():
     nodeso = 0
     while True:
 # (c) 2015, GPLv3, Daniel Preussker <f0o@devilcode.org> <<<EOC4
         global IsNode
         global distpoll
-        if distpoll is True:
+        if distpoll:
-            if IsNode is False:
+            if not IsNode:
                 memc_touch('poller.master', 10)
                 nodes = memc.get('poller.nodes')
-                if nodes is None and memc_alive() == False:
+                if nodes is None and not memc_alive():
                     print "WARNING: Lost Memcached. Taking over all devices. Nodes will quit shortly."
                     distpoll = False
                     nodes = nodeso
@@ -238,18 +256,19 @@ def printworker():
     how long it takes, and push the resulting reports to the printer queue
 """
 
+
 def poll_worker():
     while True:
         device_id = poll_queue.get()
 # (c) 2015, GPLv3, Daniel Preussker <f0o@devilcode.org> <<<EOC5
-        if distpoll == False or memc.get('poller.device.'+str(device_id)) == None:
+        if not distpoll or memc.get('poller.device.' + str(device_id)) is None:
-            if distpoll == True:
+            if distpoll:
                 result = memc.add('poller.device.' + str(device_id), config['distributed_poller_name'], 300)
-                if result == False:
+                if not result:
                     print "This device (%s) appears to be being polled by another poller" % (device_id)
                     poll_queue.task_done()
                     continue
-                if memc_alive() == False and IsNode is True:
+                if not memc_alive() and IsNode:
                     print "Lost Memcached, Not polling Device %s as Node. Master will poll it." % device_id
                     poll_queue.task_done()
                     continue
@@ -269,7 +288,8 @@ def poll_worker():
 poll_queue = Queue.Queue()
 print_queue = Queue.Queue()
 
-print "INFO: starting the poller at %s with %s threads, slowest devices first" % (time.time(), amount_of_workers)
+print "INFO: starting the poller at %s with %s threads, slowest devices first" % (time.strftime("%Y-%m-%d %H:%M:%S"),
+        amount_of_workers)
 
 for device_id in devices_list:
     poll_queue.put(device_id)
@@ -294,9 +314,9 @@ total_time = int(time.time() - s_time)
 print "INFO: poller-wrapper polled %s devices in %s seconds with %s workers" % (polled_devices, total_time, amount_of_workers)
 
 # (c) 2015, GPLv3, Daniel Preussker <f0o@devilcode.org> <<<EOC6
-if distpoll == True or memc_alive() is True:
+if distpoll or memc_alive():
     master = memc.get("poller.master")
-    if master == config['distributed_poller_name'] and IsNode == False:
+    if master == config['distributed_poller_name'] and not IsNode:
         print "Wait for all poller-nodes to finish"
         nodes = memc.get("poller.nodes")
         while nodes > 0 and nodes is not None:
@@ -321,28 +341,30 @@ if distpoll == True or memc_alive() is True:
 
 show_stopper = False
 
-query = "update pollers set last_polled=NOW(), devices='%d', time_taken='%d' where poller_name='%s'" % (polled_devices, total_time, config['distributed_poller_name'])
+query = "update pollers set last_polled=NOW(), devices='%d', time_taken='%d' where poller_name='%s'" % (polled_devices,
+        total_time, config['distributed_poller_name'])
 response = cursor.execute(query)
 if response == 1:
     db.commit()
 else:
-    query = "insert into pollers set poller_name='%s', last_polled=NOW(), devices='%d', time_taken='%d'" % (config['distributed_poller_name'],polled_devices, total_time)
+    query = "insert into pollers set poller_name='%s', last_polled=NOW(), devices='%d', time_taken='%d'" % (
+            config['distributed_poller_name'], polled_devices, total_time)
     cursor.execute(query)
     db.commit()
 db.close()
 
 
 if total_time > 300:
-    recommend = int(total_time / 300.0 * amount_of_workers + 1)
     print "WARNING: the process took more than 5 minutes to finish, you need faster hardware or more threads"
     print "INFO: in sequential style polling the elapsed time would have been: %s seconds" % real_duration
     for device in per_device_duration:
         if per_device_duration[device] > 300:
             print "WARNING: device %s is taking too long: %s seconds" % (device, per_device_duration[device])
             show_stopper = True
-    if show_stopper == True:
+    if show_stopper:
         print "ERROR: Some devices are taking more than 300 seconds, the script cannot recommend you what to do."
-    if show_stopper == False:
+    else:
+        recommend = int(total_time / 300.0 * amount_of_workers + 1)
         print "WARNING: Consider setting a minimum of %d threads. (This does not constitute professional advice!)" % recommend
 
     sys.exit(2)