diff --git a/includes/discovery/os/saf.inc.php b/includes/discovery/os/saf.inc.php index fd9ccf0685..70bd1e68b5 100644 --- a/includes/discovery/os/saf.inc.php +++ b/includes/discovery/os/saf.inc.php @@ -1,7 +1,5 @@ = 8) { - $os = 'sentry4'; - } else { - $os = 'sentry3'; - } + // It appears that version 8 and up is good for sentry4 + if ($version >= 8) { + $os = 'sentry4'; + } else { + $os = 'sentry3'; } } diff --git a/includes/discovery/os/serveriron.inc.php b/includes/discovery/os/serveriron.inc.php index 2ab8244c80..f8c8877eaa 100644 --- a/includes/discovery/os/serveriron.inc.php +++ b/includes/discovery/os/serveriron.inc.php @@ -1,18 +1,16 @@ "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Total connections in this device - "snL4slbLimitExceeds" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // exceeds snL4TCPSynLimit (numbers of connection per second) - "snL4slbForwardTraffic" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Client->Server - "snL4slbReverseTraffic" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Server->Client - "snL4slbFinished" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // FIN_or_RST - "snL4FreeSessionCount" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Maximum sessions - used sessions - "snL4unsuccessfulConn" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Unsuccessfull connection - ); +if (str_contains('ServerIron', $sysDescr)) { + $os = 'serveriron'; + $serviron_mibs = array ( + "snL4slbTotalConnections" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Total connections in this device + "snL4slbLimitExceeds" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // exceeds snL4TCPSynLimit (numbers of connection per second) + "snL4slbForwardTraffic" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Client->Server + "snL4slbReverseTraffic" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Server->Client + "snL4slbFinished" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // FIN_or_RST + "snL4FreeSessionCount" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Maximum sessions - used sessions + "snL4unsuccessfulConn" => "FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB", // Unsuccessfull connection + ); - register_mibs($device, $serviron_mibs, "includes/discovery/os/serveriron.inc.php"); - } + register_mibs($device, $serviron_mibs, "includes/discovery/os/serveriron.inc.php"); } diff --git a/includes/discovery/os/sharp.inc.php b/includes/discovery/os/sharp.inc.php index 5b93c93f3c..f48ada211f 100644 --- a/includes/discovery/os/sharp.inc.php +++ b/includes/discovery/os/sharp.inc.php @@ -1,6 +1,5 @@ */ -if (!$os) { - if (strpos($sysDescr, 'Huawei Integrated Access Software') !== false) { - $os = 'smartax'; - } +if (str_contains('Huawei Integrated Access Software', $sysDescr)) { + $os = 'smartax'; } diff --git a/includes/discovery/os/solaris.inc.php b/includes/discovery/os/solaris.inc.php index 8cbcfc34a4..674c627adc 100644 --- a/includes/discovery/os/solaris.inc.php +++ b/includes/discovery/os/solaris.inc.php @@ -1,21 +1,18 @@ '5.10') { +if (starts_with('SunOS', $sysDescr)) { + $os = 'solaris'; + list(,,$version) = explode(' ', $sysDescr); + + if(version_compare($version, '5.10', '>')) { + if (str_contains('oi_', $sysDescr)) { + $os = 'openindiana'; + } else { $os = 'opensolaris'; } - - if ($version > '5.10') { - if (preg_match('/oi_/', $sysDescr)) { - $os = 'openindiana'; - } - } - } - - if (strstr($sysObjectId, '.1.3.6.1.4.1.42.2.1.1')) { - $os = 'solaris'; } } + +if (str_contains('.1.3.6.1.4.1.42.2.1.1', $sysObjectId)) { + $os = 'solaris'; +} diff --git a/includes/discovery/os/sonicwall.inc.php b/includes/discovery/os/sonicwall.inc.php index 42a0f8640e..932f15d77c 100644 --- a/includes/discovery/os/sonicwall.inc.php +++ b/includes/discovery/os/sonicwall.inc.php @@ -1,7 +1,5 @@